Use static command discovery in @fedify/cli#808
Conversation
✅ Deploy Preview for fedify-json-schema ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughBumps ChangesCLI Command Registry and Optique v1.1 Upgrade
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI command parsing and definition structure in @fedify/cli by upgrading @optique dependencies to ^1.1.0 and introducing @optique/discover. Individual commands (such as bench, inbox, lookup, nodeinfo, relay, tunnel, and webfinger) have been refactored to separate their options and metadata, with their static definitions consolidated into a new commands.ts file. Additionally, the main entry point and runner have been updated to use the new parseCliProgram utility, accompanied by corresponding test updates. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/src/mod.ts`:
- Around line 16-47: The switch statement in the command dispatch logic uses
unsafe type casts with `as unknown as Parameters<typeof ...>[0]` which bypass
TypeScript's type checking. Create a discriminated union type or a typed handler
mapping object that associates each command string (init, generate-vocab,
webfinger, lookup, inbox, nodeinfo, relay, bench, tunnel) with its corresponding
handler and its expected parameter type. Refactor the switch statement to use
this mapping so that the value parameter gets properly type-narrowed by the
discriminated union without requiring the unsafe unknown casts, allowing
TypeScript to enforce compile-time contracts between parser output and handler
inputs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 178af8f7-242a-4cc2-adaf-4b9839195072
⛔ Files ignored due to path filters (2)
deno.lockis excluded by!**/*.lockpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (17)
deno.jsonpackages/cli/package.jsonpackages/cli/src/bench/command.tspackages/cli/src/commands.tspackages/cli/src/generate-vocab/command.tspackages/cli/src/inbox/command.tspackages/cli/src/init/mod.tspackages/cli/src/lookup.tspackages/cli/src/mod.tspackages/cli/src/nodeinfo.tspackages/cli/src/relay/command.tspackages/cli/src/runner.test.tspackages/cli/src/runner.tspackages/cli/src/startup.test.tspackages/cli/src/tunnel.tspackages/cli/src/webfinger/command.tspnpm-workspace.yaml
💤 Files with no reviewable changes (1)
- packages/cli/src/init/mod.ts
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Static CLI command definitions now carry the typed runtime handler next to the parser descriptor. The entrypoint dispatches through the parsed program without erasing each handler parameter type or casting through unknown. fedify-dev#808 (comment) Assisted-by: Codex:gpt-5.5
|
@codex review |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI command registration and execution by upgrading the @optique dependencies to version 1.1.0 and introducing @optique/discover. Individual command options and metadata have been decoupled, and a centralized commands.ts file has been created to define and group all CLI commands. The main entry point and runner have been updated to dynamically parse and run commands using the new discovery mechanism, accompanied by updated tests. There are no review comments to evaluate, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75db7c876b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Static command descriptors now import parser-only modules where available and load heavier command handlers only when the selected command runs. This keeps parse-only runner imports compatible with Node 20, where node:sqlite is not available. fedify-dev#808 (comment) Assisted-by: Codex:gpt-5.5
|
@codex review |
|
/gemini review |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/cli/src/lookup.ts (1)
75-95: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winDerive
LookupCommandfrom the parser type instead of duplicating the shape.The hand-written command type is broader than the parser contract and can silently drift. Use
InferValue<typeof import("./lookup/command.ts").lookupOptions>(or equivalent) to keeprunLookup()strictly aligned with CLI parsing output.Suggested refactor
-import { message, optionNames } from "`@optique/core`"; +import { type InferValue, message, optionNames } from "`@optique/core`"; @@ -type LookupCommand = GlobalOptions & { - readonly command: "lookup"; - readonly traverse: boolean; - readonly recurse: RecurseProperty | undefined; - readonly recurseDepth: number | undefined; - readonly suppressErrors: boolean; - readonly authorizedFetch: boolean | undefined; - readonly firstKnock: - | "draft-cavage-http-signatures-12" - | "rfc9421" - | undefined; - readonly tunnelService: TunnelService | undefined; - readonly userAgent: string; - readonly allowPrivateAddress: boolean; - readonly timeout: number | undefined; - readonly urls: readonly string[]; - readonly reverse: boolean; - readonly format: string | undefined; - readonly separator: string; - readonly output: string | undefined; -}; +type LookupCommand = GlobalOptions & InferValue< + typeof import("./lookup/command.ts").lookupOptions +>;As per coding guidelines,
**/*.tsmust maintain strict TypeScript typing throughout.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/cli/src/lookup.ts` around lines 75 - 95, The LookupCommand type is hand-written and duplicates the parser contract, which can cause it to drift out of sync with the actual CLI parsing output. Replace the manually defined LookupCommand type with a derived type that uses TypeScript's type inference from the parser's lookupOptions export (from the lookup/command.ts file). Use InferValue or equivalent type utility to automatically infer the command shape from the parser, ensuring that runLookup() is always strictly aligned with the actual CLI parsing output without manual duplication.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@packages/cli/src/lookup.ts`:
- Around line 75-95: The LookupCommand type is hand-written and duplicates the
parser contract, which can cause it to drift out of sync with the actual CLI
parsing output. Replace the manually defined LookupCommand type with a derived
type that uses TypeScript's type inference from the parser's lookupOptions
export (from the lookup/command.ts file). Use InferValue or equivalent type
utility to automatically infer the command shape from the parser, ensuring that
runLookup() is always strictly aligned with the actual CLI parsing output
without manual duplication.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3d3ed876-8a1f-48a0-a197-9471b14c87cc
📒 Files selected for processing (3)
packages/cli/src/commands.tspackages/cli/src/lookup.tspackages/cli/src/lookup/command.ts
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI command registration and execution by adopting the @optique/discover package. It separates options and metadata definitions for all commands (such as bench, inbox, lookup, nodeinfo, relay, tunnel, and webfinger) and centralizes command routing into a new commands.ts file. This allows the main entry point to dynamically parse and execute commands using a unified CliProgram runner. Feedback on the changes suggests renaming a destructured variable run in runner.ts to avoid shadowing the imported run function from @optique/run.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The parsed command runner was destructured into a local variable named run inside the module that imports Optique's run helper. Rename the local binding to make the dispatch path unambiguous. fedify-dev#808 (comment) Assisted-by: Codex:gpt-5.5
|
@codex review |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI command structure by upgrading @optique packages to version 1.1.0 and integrating @optique/discover for command definition and routing. Command options and metadata have been modularized across individual command files, and a centralized commands.ts file has been introduced to manage command groups. A critical TypeScript compilation error was identified in packages/cli/src/lookup.ts where lookupOptions is imported as a type but referenced as a value in a typeof type query.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Upgrade Optique to 1.1.0 and register CLI commands as static command descriptors. This keeps the command tree discoverable without runtime file scanning, so `deno compile` packaging continues to work. Dispatch the selected static command from the parsed program and await all command handlers so asynchronous failures remain observable. dahlia/optique#834 Assisted-by: Codex:gpt-5.5
Static CLI command definitions now carry the typed runtime handler next to the parser descriptor. The entrypoint dispatches through the parsed program without erasing each handler parameter type or casting through unknown. fedify-dev#808 (comment) Assisted-by: Codex:gpt-5.5
Static command descriptors now import parser-only modules where available and load heavier command handlers only when the selected command runs. This keeps parse-only runner imports compatible with Node 20, where node:sqlite is not available. fedify-dev#808 (comment) Assisted-by: Codex:gpt-5.5
The lookup runner used a hand-written command value type that duplicated the parser output shape. This made the runner easy to drift from lookupOptions as new flags moved into the command parser. Infer the command value from lookupOptions so runLookup stays aligned with the actual parser contract. Assisted-by: Codex:gpt-5.5
The parsed command runner was destructured into a local variable named run inside the module that imports Optique's run helper. Rename the local binding to make the dispatch path unambiguous. fedify-dev#808 (comment) Assisted-by: Codex:gpt-5.5
The rebased branch now sits on top of benchmark comparison support. The static command registry must load the dispatcher that handles both run and compare modes instead of loading the run-only action directly. Assisted-by: Codex:gpt-5.5
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/src/runner.ts`:
- Around line 243-255: The toCliProgram function extracts and strips internal
properties (selectedCommand and selectedRun) from the parsed object into the
value variable, but the run function being returned still passes the original
unparsed object to runCommand. This means the internal tagged properties
(__fedifyCliSelectedCommand and __fedifyCliRunCommand) are still forwarded to
command handlers. Instead of passing the full parsed object, pass the
already-stripped value object to runCommand so that only the cleaned command
arguments are forwarded to handlers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d14680a6-1a14-4ce5-b800-8d6fee34727f
⛔ Files ignored due to path filters (2)
deno.lockis excluded by!**/*.lockpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (18)
deno.jsonpackages/cli/package.jsonpackages/cli/src/bench/command.tspackages/cli/src/commands.tspackages/cli/src/generate-vocab/command.tspackages/cli/src/inbox/command.tspackages/cli/src/init/mod.tspackages/cli/src/lookup.tspackages/cli/src/lookup/command.tspackages/cli/src/mod.tspackages/cli/src/nodeinfo.tspackages/cli/src/relay/command.tspackages/cli/src/runner.test.tspackages/cli/src/runner.tspackages/cli/src/startup.test.tspackages/cli/src/tunnel.tspackages/cli/src/webfinger/command.tspnpm-workspace.yaml
💤 Files with no reviewable changes (1)
- packages/cli/src/init/mod.ts
The parsed CLI value carries private marker fields used to identify and run the selected static command. Reuse the public value when dispatching through parseCliProgram so command handlers do not receive those internal fields. fedify-dev#808 (comment) Assisted-by: Codex:gpt-5.5
|
/gemini review |
|
@codex review |
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI command structure to use @optique/discover for dynamic command definition and parsing, separating command options and metadata from their execution logic. It also updates dependencies to @optique version 1.1.0 and simplifies the main entry point. Feedback on the changes highlights a TypeScript compilation error in lookup.ts due to importing lookupOptions as a type instead of a value, and suggests avoiding the use of as never for type assertion in tests to maintain type safety.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The runner regression test still needs to construct a synthetic parsed value, but it can assert the parameter type expected by toCliProgram instead of bypassing type checking with never. fedify-dev#808 (comment) Assisted-by: Codex:gpt-5.5
|
@codex review |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI command registration and execution structure by upgrading the @optique dependencies to version 1.1.0 and introducing @optique/discover. It extracts options and metadata from individual command definitions (such as bench, generate-vocab, inbox, lookup, nodeinfo, relay, tunnel, and webfinger) and consolidates command definitions into a new commands.ts file. The main entry point (mod.ts) and the runner (runner.ts) are simplified to dynamically parse and execute these commands using the new discover utility. Additionally, unit tests are added to verify the CLI program parsing and execution. There are no review comments to address, and I have no further feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
What changed
This PR updates
@fedify/clito Optique 1.1.0 and moves the CLI command tree to static command descriptors from@optique/discover. The new packages/cli/src/commands.ts registry declares the available commands withdefineCommand(), while each command module now exports its option parser and metadata separately. The existing*Commandexports stay in place for tests and direct parser use.packages/cli/src/runner.ts composes those static descriptors into the same grouped command layout the CLI already exposed. It keeps the selected command as internal parse state, then strips that marker from the public
runCli()result. packages/cli/src/mod.ts uses the selected command path to dispatch to the existing handlers and now awaits every async branch.The dependency update touches deno.json, deno.lock, pnpm-workspace.yaml, pnpm-lock.yaml, and packages/cli/package.json. It upgrades
@optique/config,@optique/core, and@optique/runto 1.1.0, then adds@optique/discoverfor the CLI package.Why static commands
Optique 1.1.0 added command discovery, including a file-system discovery mode and a static command mode. File-system discovery is convenient for many CLIs, but
@fedify/cliis also built withdeno compile. Static descriptors give the CLI a discoverable command registry without depending on runtime file scanning or dynamic command imports in the standalone executable.This follows the Optique 1.1.0 command discovery work discussed at dahlia/optique#834.
Testing
git diff --checkdeno task -f @fedify/cli checkpnpm --filter @fedify/cli testdeno task -f @fedify/cli testOS=linux ARCH=x86_64 CONCURRENCY=1 deno task -f @fedify/cli pack