Skip to content

enhance: accept WebP as profile avatar/banner images #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dahlia merged 1 commit into from
Jun 19, 2026
+16 −6
Merged

enhance: accept WebP as profile avatar/banner images #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/api/v1/accounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,12 @@ import { isUuid, type Uuid } from "../../uuid";
import { timelineQuerySchema } from "./timelines";

const app = new Hono<{ Variables: AccountOwnerVariables }>();
const allowedImageMimeTypes = ["image/gif", "image/jpeg", "image/png"];
const allowedImageMimeTypes = [
"image/gif",
"image/jpeg",
"image/png",
"image/webp",
];

app.get(
"/verify_credentials",
Expand Down
15 changes: 10 additions & 5 deletions src/pages/accounts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ const HOLLO_OFFICIAL_ACCOUNT = "@hollo@hollo.social";

const logger = getLogger(["hollo", "pages", "accounts"]);

const allowedImageMimeTypes = ["image/gif", "image/jpeg", "image/png"];
const allowedImageMimeTypes = [
"image/gif",
"image/jpeg",
"image/png",
"image/webp",
];
Comment thread
naskya marked this conversation as resolved.

export function parseFields(
form: FormData,
Expand Down Expand Up @@ -194,7 +199,7 @@ accounts.post("/", async (c) => {
news,
fields: parsedFields,
}}
errors={{ avatar: "Avatar must be a JPEG, PNG, or GIF." }}
errors={{ avatar: "Avatar must be a JPEG, PNG, WEBP, or GIF." }}
officialAccount={HOLLO_OFFICIAL_ACCOUNT}
host={getInstanceHost(new URL(c.req.url))}
/>,
Expand Down Expand Up @@ -222,7 +227,7 @@ accounts.post("/", async (c) => {
news,
fields: parsedFields,
}}
errors={{ header: "Header image must be a JPEG, PNG, or GIF." }}
errors={{ header: "Header image must be a JPEG, PNG, WEBP, or GIF." }}
officialAccount={HOLLO_OFFICIAL_ACCOUNT}
host={getInstanceHost(new URL(c.req.url))}
/>,
Expand Down Expand Up @@ -596,7 +601,7 @@ accounts.post("/:id", async (c) => {
coverUrl: accountOwner.account.coverUrl,
fields: parsedFields,
}}
errors={{ avatar: "Avatar must be a JPEG, PNG, or GIF." }}
errors={{ avatar: "Avatar must be a JPEG, PNG, WEBP, or GIF." }}
officialAccount={HOLLO_OFFICIAL_ACCOUNT}
host={getInstanceHost(new URL(c.req.url))}
/>,
Expand Down Expand Up @@ -627,7 +632,7 @@ accounts.post("/:id", async (c) => {
coverUrl: accountOwner.account.coverUrl,
fields: parsedFields,
}}
errors={{ header: "Header image must be a JPEG, PNG, or GIF." }}
errors={{ header: "Header image must be a JPEG, PNG, WEBP, or GIF." }}
officialAccount={HOLLO_OFFICIAL_ACCOUNT}
host={getInstanceHost(new URL(c.req.url))}
/>,
Expand Down
Loading