fix(web): CORS preflight bypasses security gate (v26.06.109)#141
Merged
Conversation
…y gate (v26.06.109)
The CORSMiddleware is now prepended ahead of the WebFilterChain (which holds the
HttpSecurity gate) on both the Starlette and FastAPI adapters. Previously the
filter chain wrapped CORS, so a browser OPTIONS preflight (no credentials) to a
gated route was answered 401 without Access-Control-* headers and the browser
blocked the real request ('Load failed'). Regression test added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORSMiddleware is now the outermost middleware (ahead of the WebFilterChain holding the HttpSecurity gate) on both adapters, so a credential-less OPTIONS preflight to a gated route is answered by CORS (200 + Access-Control-* headers) instead of being 401'd by the gate — which made browsers report 'Load failed'. Regression test added (tests/web/test_cors.py). Bump v26.06.108 → v26.06.109.
🤖 Generated with Claude Code