Skip to content

feat: add groups tab in config access and bifurcate users and groups - #3089

Merged
moshloop merged 1 commit into
mainfrom
add-groups-tab
Aug 12, 2026
Merged

feat: add groups tab in config access and bifurcate users and groups#3089
moshloop merged 1 commit into
mainfrom
add-groups-tab

Conversation

@yashmehrotra

@yashmehrotra yashmehrotra commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added a Groups view for configuration access, with pagination, sorting, and drill-down by group.
    • Added group-based filtering through a new Group dropdown.
    • Added group identity, user, role, catalog, sign-in, and grant details to the access table.
    • Updated URL state and navigation to support the new Groups view.
  • Bug Fixes
    • External-user searches now exclude grouped-user records.

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aws-preview Ready Ready Preview Aug 12, 2026 8:34am
flanksource-ui Ready Ready Preview Aug 12, 2026 8:34am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 804aba02-9384-4500-94df-30db88eb0dcb

📥 Commits

Reviewing files that changed from the base of the PR and between 95a5ef7 and 9c9c697.

📒 Files selected for processing (14)
  • src/api/query-hooks/useConfigAccessGroupedQuery.ts
  • src/api/services/__tests__/configAccess.externalUsers.unit.test.ts
  • src/api/services/__tests__/configAccess.grouped.unit.test.ts
  • src/api/services/configAccess.ts
  • src/api/types/configs.ts
  • src/components/Configs/Access/ConfigAccessFilters.tsx
  • src/components/Configs/Access/ConfigAccessGroupByTabs.tsx
  • src/components/Configs/Access/__tests__/ConfigAccessGroupByTabs.unit.test.tsx
  • src/components/Configs/Access/tables/ConfigAccessGroupedByGroupTable.tsx
  • src/components/Configs/Access/tables/cells.tsx
  • src/components/Configs/Access/utils.ts
  • src/hooks/__tests__/useCatalogAccessUrlState.unit.test.ts
  • src/hooks/useCatalogAccessUrlState.ts
  • src/pages/config/ConfigAccessPage.tsx

Walkthrough

The PR adds group-based configuration access summaries, filtering, URL-state handling, drill-down navigation, and a server-paginated group table.

Changes

Grouped configuration access

Layer / File(s) Summary
API contracts and grouped summaries
src/api/types/configs.ts, src/api/services/configAccess.ts, src/api/services/__tests__/configAccess.*.unit.test.ts
Adds group summary types and queries. Adds group filter options. Excludes grouped users from external-user searches.
Grouped access query hook
src/api/query-hooks/useConfigAccessGroupedQuery.ts
Adds useConfigAccessGroupedByGroupQuery with pagination, sorting, React Query state, and previous-data retention.
Group mode, filters, and navigation
src/hooks/useCatalogAccessUrlState.ts, src/hooks/__tests__/useCatalogAccessUrlState.unit.test.ts, src/components/Configs/Access/ConfigAccessFilters.tsx, src/components/Configs/Access/ConfigAccessGroupByTabs.tsx, src/components/Configs/Access/__tests__/ConfigAccessGroupByTabs.unit.test.tsx, src/components/Configs/Access/utils.ts
Adds the group-group mode, external group filters, group tabs, URL mapping, drill-down behavior, and page-index reset handling.
Group table and page integration
src/components/Configs/Access/tables/ConfigAccessGroupedByGroupTable.tsx, src/components/Configs/Access/tables/cells.tsx, src/pages/config/ConfigAccessPage.tsx
Adds the grouped-by-group table, group-specific cells, server pagination, sorting, error handling, loading states, and page rendering.

Sequence Diagram(s)

sequenceDiagram
  participant ConfigAccessPage
  participant ConfigAccessGroupedByGroupTable
  participant useConfigAccessGroupedByGroupQuery
  participant getConfigAccessSummaryByGroup
  ConfigAccessPage->>ConfigAccessGroupedByGroupTable: render group-group mode
  ConfigAccessGroupedByGroupTable->>useConfigAccessGroupedByGroupQuery: request paginated and sorted data
  useConfigAccessGroupedByGroupQuery->>getConfigAccessSummaryByGroup: fetch group summaries
  getConfigAccessSummaryByGroup-->>useConfigAccessGroupedByGroupQuery: return rows and count
  useConfigAccessGroupedByGroupQuery-->>ConfigAccessGroupedByGroupTable: provide table data
  ConfigAccessGroupedByGroupTable->>ConfigAccessPage: drill down by external group ID
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 5.88% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding a Groups tab and separating user- and group-based configuration access.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-groups-tab
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch add-groups-tab

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@moshloop
moshloop merged commit 6a8f2f2 into main Aug 12, 2026
16 of 18 checks passed
@moshloop
moshloop deleted the add-groups-tab branch August 12, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants