[2.x] fix: PHPStan errors under phpstan 2.2.6 / illuminate 13.22#4842
Merged
Conversation
phpstan 2.2.6 with illuminate/database 13.22.0 flags the two when*/unless* driver macros for accessing the protected $query property on the builder union. The access was runtime-legal (macro closures are scope-bound to the builder), but read the property directly. Switch to the public getQuery() accessor, which resolves the same connection on every supported illuminate version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpstan 2.2.6 with illuminate/database 13.22.0 (both released after 2.x's last green run) flag the two
when*/unless*database driver macros inDatabaseServiceProviderfor accessing the protected$queryproperty on theBuilder|Query\Builderunion — failing Static Analysis on every 2.x push.The access was runtime-legal (macro closures are scope-bound to the builder via
Closure::call()), but read the property directly. This switches to the publicgetQuery()accessor, which resolves the same connection on every supported illuminate version.Unblocks 2.x CI. Verified: PHPStan clean and the database integration tests pass against phpstan 2.2.6 / illuminate 13.22.0 locally.