Skip to content

fix(ui): Use real design tokens so borders and surfaces render #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nfebe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): Use real design tokens so borders and surfaces render #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/views/APIKeysView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,15 +601,15 @@ onMounted(() => {
justify-content: center;
padding: 3rem;
gap: 1rem;
color: var(--text-secondary);
color: var(--text-muted);
}

.error-state {
color: var(--danger);
}

.apikeys-table-container {
background: var(--surface-card);
background: var(--surface-raised);
border-radius: 8px;
border: 1px solid var(--surface-border);
overflow: hidden;
Expand All @@ -628,9 +628,9 @@ onMounted(() => {
}

.data-table th {
background: var(--surface-ground);
background: var(--surface-sunken);
font-weight: 600;
color: var(--text-secondary);
color: var(--text-muted);
font-size: 0.8125rem;
text-transform: uppercase;
}
Expand All @@ -656,12 +656,12 @@ onMounted(() => {

.key-desc {
font-size: 0.75rem;
color: var(--text-secondary);
color: var(--text-muted);
}

code {
padding: 0.25rem 0.5rem;
background: var(--surface-ground);
background: var(--surface-sunken);
border-radius: 4px;
font-family: monospace;
font-size: 0.8125rem;
Expand Down Expand Up @@ -693,7 +693,7 @@ code {

.role-badge.inherit {
background: rgba(var(--text-secondary-rgb), 0.1);
color: var(--text-secondary);
color: var(--text-muted);
}

.status-badge {
Expand All @@ -711,7 +711,7 @@ code {

.status-badge.inactive {
background: rgba(var(--text-secondary-rgb), 0.1);
color: var(--text-secondary);
color: var(--text-muted);
}

.actions-cell {
Expand All @@ -733,7 +733,7 @@ code {
}

.modal-content {
background: var(--surface-card);
background: var(--surface-raised);
border-radius: var(--radius-xl);
width: 100%;
max-width: 960px;
Expand Down Expand Up @@ -789,7 +789,7 @@ code {
display: block;
margin-bottom: 0.5rem;
font-weight: 500;
color: var(--text-secondary);
color: var(--text-muted);
}

.form-group input,
Expand All @@ -798,15 +798,15 @@ code {
padding: 0.5rem 0.75rem;
border: 1px solid var(--surface-border);
border-radius: 4px;
background: var(--surface-ground);
background: var(--surface-sunken);
color: var(--text-primary);
}

.form-group small {
display: block;
margin-top: 0.25rem;
font-size: 0.75rem;
color: var(--text-secondary);
color: var(--text-muted);
}

.checkbox-label {
Expand Down Expand Up @@ -849,7 +849,7 @@ code {
align-items: center;
gap: 0.5rem;
padding: 0.75rem;
background: var(--surface-ground);
background: var(--surface-sunken);
border-radius: 4px;
}

Expand All @@ -867,7 +867,7 @@ code {
padding: 0.5rem 1rem;
border: none;
border-radius: 4px;
background: var(--surface-ground);
background: var(--surface-sunken);
color: var(--text-primary);
cursor: pointer;
font-size: 0.875rem;
Expand Down
46 changes: 26 additions & 20 deletions src/views/AgentsView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ onMounted(fetchAgents);
}

.subtitle {
color: var(--text-secondary);
color: var(--text-muted);
margin-top: var(--space-1);
}

Expand All @@ -249,14 +249,14 @@ onMounted(fetchAgents);
align-items: center;
gap: var(--space-3);
padding: var(--space-10) var(--space-6);
color: var(--text-secondary);
color: var(--text-muted);
text-align: center;
}

.empty-state .example {
text-align: left;
background: var(--surface-ground);
border: 1px solid var(--border-color);
background: var(--surface-sunken);
border: 1px solid var(--border);

@sourceant sourceant Bot Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent border token. APIKeysView.vue and UsersView.vue consistently use var(--surface-border) (e.g., line 614 and 434 respectively), while AgentsView.vue uses var(--border). Using var(--surface-border) here would maintain consistency across all updated views.

Suggested change
border: 1px solid var(--border);
+ border: 1px solid var(--surface-border);

border-radius: 8px;
padding: var(--space-4);
font-size: 0.82rem;
Expand All @@ -276,8 +276,8 @@ onMounted(fetchAgents);
align-items: center;
gap: var(--space-4);
padding: var(--space-4);
background: var(--surface-card);
border: 1px solid var(--border-color);
background: var(--surface-raised);
border: 1px solid var(--border);
border-radius: 10px;
}

Expand All @@ -296,14 +296,14 @@ onMounted(fetchAgents);
font-size: 0.72rem;
padding: 0.15rem 0.5rem;
border-radius: 50px;
background: var(--surface-ground);
border: 1px solid var(--border-color);
color: var(--text-secondary);
background: var(--surface-sunken);
border: 1px solid var(--border);
color: var(--text-muted);
}

.agent-description {
margin: var(--space-1) 0 0;
color: var(--text-secondary);
color: var(--text-muted);
font-size: 0.88rem;
}

Expand All @@ -314,20 +314,26 @@ onMounted(fetchAgents);
flex-shrink: 0;
}

.header-actions {
display: flex;
gap: var(--space-2);
align-items: center;
}

.modal-overlay {
position: fixed;
inset: 0;
background: rgba(0, 0, 0, 0.55);
display: flex;
align-items: center;
justify-content: center;
z-index: 1000;
z-index: var(--z-modal);
}

.modal-container.agent-editor {
width: min(720px, 92vw);
background: var(--surface-card);
border: 1px solid var(--border-color);
background: var(--surface-raised);
border: 1px solid var(--border);
border-radius: 12px;
display: flex;
flex-direction: column;
Expand All @@ -339,7 +345,7 @@ onMounted(fetchAgents);
align-items: center;
gap: var(--space-2);
padding: var(--space-4);
border-bottom: 1px solid var(--border-color);
border-bottom: 1px solid var(--border);
}

.modal-header h3 {
Expand All @@ -354,7 +360,7 @@ onMounted(fetchAgents);
.close-btn {
background: none;
border: none;
color: var(--text-secondary);
color: var(--text-muted);
cursor: pointer;
padding: var(--space-1);
}
Expand All @@ -370,24 +376,24 @@ onMounted(fetchAgents);
display: block;
margin-bottom: var(--space-1);
font-size: 0.85rem;
color: var(--text-secondary);
color: var(--text-muted);
}

.form-control {
width: 100%;
padding: 0.5rem 0.75rem;
background: var(--surface-ground);
border: 1px solid var(--border-color);
background: var(--surface-sunken);
border: 1px solid var(--border);
border-radius: 8px;
color: var(--text-color);
color: var(--text);

@sourceant sourceant Bot Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent text color token. Other views use var(--text-primary) for form controls (e.g., APIKeysView.vue:802). Standardizing on var(--text-primary) instead of var(--text) ensures cohesive rendering and better theme support across the application.

Suggested change
color: var(--text);
+ color: var(--text-primary);

}

.modal-footer {
display: flex;
gap: var(--space-2);
align-items: center;
padding: var(--space-4);
border-top: 1px solid var(--border-color);
border-top: 1px solid var(--border);
}

.footer-spacer {
Expand Down
Loading
Loading