[CMake] - Update precompiled libraries links#601
Closed
goliaro wants to merge 8 commits into
Closed
Conversation
Collaborator
Author
|
Looks like we will have to use a solution like this to get the path at runtime: https://gist.github.com/gabrieleoliaro/51b75482ba26143b0cca5841cab96d38 |
Collaborator
Author
|
This PR depends on #590 , so we are waiting on that to finish before continuing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
PR flexflow/flexflow-third-party#13 fixes a lot of lingering issues regarding the use of pre-compiled NCCL and Legion, and having fixed a Legion CMake bug, we can now pre-build for many python versions, without having to worry about the location of the Python library on the system. This PR updates the FlexFlow codebase to be able to take advantage of the changes. In particular, we update the URLs were the nccl & legion libraries are stored.
Related Issues:
Linked Issues:
Issues closed by this PR:
Before merging: