Skip to content

refactor: remove legacy scenario commands and GraphQL support#237

Open
odinellefsen wants to merge 1 commit into
mainfrom
removing-graphql-commands
Open

refactor: remove legacy scenario commands and GraphQL support#237
odinellefsen wants to merge 1 commit into
mainfrom
removing-graphql-commands

Conversation

@odinellefsen

@odinellefsen odinellefsen commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This commit removes several legacy scenario commands, including fetch, list, restart, and delete functionalities, along with their associated GraphQL command structure. The command-graphql.ts file and related types in legacy-scenario.ts have also been deleted to streamline the codebase. The main module exports have been updated accordingly to reflect these removals.

Summary by CodeRabbit

  • Refactor
    • Removed legacy scenario command support from the public API.
    • Cleaned up related scenario data contracts and shared GraphQL command plumbing.
    • Removed outdated automated coverage for the legacy scenario flows.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@odinellefsen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0ec371ee-a532-43bf-9840-56d89db2a634

📥 Commits

Reviewing files that changed from the base of the PR and between 50464fb and 2e13f47.

📒 Files selected for processing (11)
  • src/commands/index.ts
  • src/commands/legacy-scenario/legacy-scenario-adapter.fetch-state.ts
  • src/commands/legacy-scenario/legacy-scenario-adapter.restart.ts
  • src/commands/legacy-scenario/legacy-scenario.delete.ts
  • src/commands/legacy-scenario/legacy-scenario.fetch.ts
  • src/commands/legacy-scenario/legacy-scenario.list.ts
  • src/common/command-graphql.ts
  • src/contracts/index.ts
  • src/contracts/legacy-scenario.ts
  • src/mod.ts
  • test/tests/commands/legacy-scenario.test.ts
📝 Walkthrough

Walkthrough

This PR removes the legacy GraphQL-based scenario command implementations (delete, fetch, list, adapter fetch-state, adapter restart), their associated contracts/schemas, the GraphQlCommand base class, and their barrel re-exports across index/mod files, along with the corresponding test suite.

Changes

Legacy Scenario Removal

Layer / File(s) Summary
Legacy scenario command implementations removed
src/commands/legacy-scenario/*, test/tests/commands/legacy-scenario.test.ts
Deletes GraphQL-based delete, fetch, list, adapter fetch-state, and adapter restart commands and their test suite.
Legacy scenario contracts removed
src/contracts/legacy-scenario.ts
Deletes TypeBox schemas and types for legacy scenario deployment state, node types, and adapter state.
GraphQlCommand base class removed
src/common/command-graphql.ts
Deletes the abstract GraphQlCommand class used by legacy GraphQL commands.
Barrel export cleanup
src/commands/index.ts, src/contracts/index.ts, src/mod.ts
Removes re-exports referencing the deleted legacy scenario commands, contracts, and GraphQlCommand.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: suuunly, jbiskur

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing legacy scenario commands and their GraphQL support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch removing-graphql-commands

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Cursor <cursoragent@cursor.com>
@odinellefsen odinellefsen force-pushed the removing-graphql-commands branch from 50464fb to 2e13f47 Compare July 3, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant