Skip to content

[tizen_app_manager] Add integration tests#1049

Merged
seungsoo47 merged 4 commits into
flutter-tizen:masterfrom
seungsoo47:tizen_app_manager-add-integration-tests
Jul 1, 2026
Merged

[tizen_app_manager] Add integration tests#1049
seungsoo47 merged 4 commits into
flutter-tizen:masterfrom
seungsoo47:tizen_app_manager-add-integration-tests

Conversation

@seungsoo47

@seungsoo47 seungsoo47 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Fix a memory leak in AppRunningContext.packageId where the native string returned by app_context_get_package_id was not freed, and add 9 integration test cases covering AppManager and AppRunningContext APIs.

#1039

seungsoo47 and others added 2 commits June 30, 2026 14:28
Add regression integration test cases for tizen_app_manager public API:
- AppManager.getInstalledApps: returns non-empty list
- AppManager.getInstalledApps: includes the current app
- AppManager.isRunning: returns true for running app
- AppManager.isRunning: returns false for non-running app
- AppManager.isRunning: throws ArgumentError for empty appId
- AppManager.getAppInfo: returns all AppInfo fields
- AppManager.getAppInfo: throws ArgumentError for empty appId
- AppRunningContext: packageId matches current app
- AppRunningContext: throws PlatformException for non-running appId

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The native string returned by app_context_get_package_id must be released
with free() per the API contract, but was never freed. This caused heap
corruption when multiple tests called packageId, leading to crashes in
subsequent native calls.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a memory leak in AppContext by freeing the native string pointer returned by app_context_get_package_id after converting it to a Dart string. Additionally, it introduces integration tests for AppManager and AppRunningContext within the example application, and updates the changelog. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@JSUYA JSUYA changed the title Tizen app manager add integration tests [tizen_app_manager] Add integration tests Jun 30, 2026
Comment thread packages/tizen_app_manager/CHANGELOG.md Outdated
@seungsoo47 seungsoo47 merged commit 62e2337 into flutter-tizen:master Jul 1, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants