[tizen_audio_manager] Add regression integration tests#1050
Merged
seungsoo47 merged 2 commits intoJul 1, 2026
Merged
Conversation
Add 2 integration test cases for previously untested public API: - currentPlaybackType returns a valid AudioVolumeType: verifies the getter returns a recognized enum value. - onChanged emits VolumeChangedEvent when volume is changed: subscribes to the stream, triggers a volume change via setLevel, and asserts the emitted event carries the correct type and level. All 19 tests pass on the Samsung TV emulator (T-samsung-10.0-x86_64).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds two integration tests to audio_manager_test.dart to verify currentPlaybackType and the onChanged event stream, and updates the changelog. Feedback suggests wrapping the volume level restoration and stream subscription cancellation in a try-finally block to ensure cleanup occurs even if the test fails or times out.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Wrap the onChanged stream test body in a try-finally block so that the original volume is restored and the stream subscription is cancelled even when the timeout or an assertion fails.
JSUYA
reviewed
Jul 1, 2026
JSUYA
approved these changes
Jul 1, 2026
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 integration test cases for previously untested public API:
All 19 tests pass on the Samsung TV emulator (T-samsung-10.0-x86_64).
#1039