[tizen_window_manager] Add regression integration tests#1053
[tizen_window_manager] Add regression integration tests#1053seungsoo47 wants to merge 3 commits into
Conversation
* WindowManager.getGeometry returns a map with all required keys * WindowManager.getGeometry returns integer values for all geometry fields * WindowManager.getGeometry returns positive dimensions * WindowManager.lower completes without error and window can be reactivated
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds integration tests for WindowManager.getGeometry and WindowManager.lower to the Tizen window manager example, and updates the changelog. The review feedback recommends consolidating the three getGeometry tests into a single test to reduce platform channel calls and eliminate redundant type assertions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
getGeometry returns Map<String, int> via Map<String, int>.from(), which throws a TypeError if any value is not an int, so the values are guaranteed to be ints by the time the test reads them. Drop the 'returns integer values' test whose isA<int>() assertions therefore verify nothing; key presence and positive dimensions remain covered by the other tests.
| expect(WidgetsBinding.instance.lifecycleState, AppLifecycleState.resumed); | ||
| }); | ||
|
|
||
| group('WindowManager.getGeometry', () { |
There was a problem hiding this comment.
This duplicates the Can get window geometry info test. Please integrate or remove the tests.
| }); | ||
| }); | ||
|
|
||
| group('WindowManager.lower', () { |
There was a problem hiding this comment.
This duplicates the `Control lower/activate window' test. Please integrate or remove the tests.
| testWidgets('completes without error and window can be reactivated', | ||
| (WidgetTester tester) async { | ||
| await expectLater(WindowManager.lower(), completes); | ||
| await Future<void>.delayed(const Duration(seconds: 1)); |
There was a problem hiding this comment.
1 second looks a bit tight. I recommend at least 2 to 3 seconds.
| @@ -1,3 +1,7 @@ | |||
| ## NEXT | |||
|
|
|||
| * Add 4 integration test cases. | |||
There was a problem hiding this comment.
There are actually 3 testWidgets added.
2 participants
Add regression integration tests covering the public API of
tizen_window_manager:WindowManager.getGeometry: returns a map with all required keys (x,y,width,height) and integer values;widthandheightare positiveWindowManager.lower: completes without error and window can be reactivatedValidated on RPi4 and TV emulator.
#1039