Add Material style variant enum#12221
Conversation
|
Seems no need to add tests. I'll request test exemption when we merge changes to main (after v1.0.0). |
There was a problem hiding this comment.
Code Review
This pull request introduces the StyleVariant enum to theme_data.dart, defining the material3 and material3Expressive style variants. The review feedback suggests renaming StyleVariant to MaterialStyleVariant to prevent namespace pollution and maintain consistency with other Material-specific enums, alongside a minor capitalization correction in the documentation.
|
Should we hold this PR to after the v1.0.0 release? I thought the v1.0.0 release was meant to be as close to |
Yes, this PR will only be merged in m3e_migration feature branch. Once we have v1.0.0 release, we will move the commits in this feature branch to main:). So we will not have any expressive-related change before v1.0.0 in material_ui. |
|
That's awesome! Didn't notice it's targeting a new branch. |
Related to Bring Material 3 Expressive to Flutter
This PR is just to add the
StyleVariantenum so we can start migrating individual components.Pre-Review Checklist
[shared_preferences]///).