Conversation
|
Staged preview of the updated docs.flutter.dev site (updated for commit e471176): https://flutter-docs-prod--docs-pr13558-feat-blog-drugp8f0.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit e471176): https://flutter-dev-230821--www-pr13558-feat-blog-aajb5l2g.web.app |
|
To be honest, I don't like blog systems without comment features. |
Thanks for the feedback! Once our blogs are both migrated and given some time in production, depending on community feedback, we might consider investigating support for comments and/or reactions. It requires additional planning, work, and process due to involving user data, so we won't be including support as part of this initial implementation. In the mean time, blog posts can be (and often are) discussed on some of the great Flutter communities or on social media. |
|
Thanks for the hard work on this @schultek! Just commenting a few issues, notes, and ideas from our discussion so they don't get lost:
Questions:
|
There was a problem hiding this comment.
@parlough About these new github links:
When I created the list of authors, I manually went through all of them and only included github links for those that appear to have an active prescense on Github. If someone has an account that doesn't do anything I left it out. I don't want to link to peoples old/inactive accounts, that has no value.
(Referring to 80b831b)
There was a problem hiding this comment.
Code Review
This pull request implements a new blog system, adding several UI components, data models, and Atom feed generation. It also updates the site layout to include improved social media meta tags and adds necessary dependencies for internationalization and XML processing. The code review identified several critical runtime issues, specifically regarding YAML map parsing, frontmatter date handling, and page filtering logic that could cause build crashes. Additionally, a null-safety improvement for the clipboard API was suggested. All review comments are actionable and address potential stability and safety issues; therefore, no comments were removed.
Implements the Flutter Blog as part of the marketing site using Jaspr.
sites/www/content/blog.sites/www/content/blog/authors.yaml.Preview: https://flutter-dev-230821--www-pr13558-feat-blog-aajb5l2g.web.app/blog
Contributes to #13507