Bump requirements to avoid gcsfs close spam#3436
Merged
Merged
Conversation
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pingsutw
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Picks up fix in fsspec/gcsfs#606 to reduce log spam
gcsfs's ClientSession/Connector close is being driven by the GC weakref callback at process teardown, lands in fsspec/asyn.py:_runner → asyncio.wait_for, and the underlying aiohttp/connector.py:1044 close raises because the loop is wrong/closed. PR #606 changes the cleanup to always use the session's associated event loop rather than get_event_loop()'s newly-created idle one.
This results in noisy task logs that frequently include
What changes were proposed in this pull request?
See PR title, bumps gcsfs and aiohttp
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link