Add selectable markdown context menu builder#134
Open
momadvisor wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contextMenuBuilderparameter toMarkdownandMarkdownBody.SelectableText.richwidgets whenselectableis enabled.contextMenuBuilder: nullto suppress the selectable text context menu.TextSpan.toPlainText(), so callers receive the full selectable plain text even when markdown produces rich/nested spans.Motivation
Apps embedding selectable markdown may already provide their own surrounding context menu. Without a way to customize or suppress the internal
SelectableTextcontext menu, right-click/long-touch behavior can conflict with the app-level menu.Also, consumers that implement their own selection-related UI need reliable plain text from
onSelectionChanged. For rich markdown spans, using onlyTextSpan.textcan be null or incomplete, whiletoPlainText()reflects the rendered selectable text.Tests
flutter test test/context_menu_builder_test.dartflutter analyze