Skip to content

Added ability to set connection timeout values.#12

Open
jim0020 wants to merge 1 commit into
foursquare:masterfrom
jim0020:master
Open

Added ability to set connection timeout values.#12
jim0020 wants to merge 1 commit into
foursquare:masterfrom
jim0020:master

Conversation

@jim0020

@jim0020 jim0020 commented Feb 14, 2013

Copy link
Copy Markdown

Can set a connection timeout value, in seconds (NSTimeInterval), as a default for all FSNConnection instances, and individually.

@mattchukabam

Copy link
Copy Markdown

That looks good to me. @gwk Good enough to merge?

@gwk

gwk commented Feb 20, 2013

Copy link
Copy Markdown
Contributor

this looks fine to me. style points:

  • method braces are inconsistent with the rest of the project.
  • i would not use double-underscore prefix for a static variable, because i think of those as being reserved for macro temps and compiler internals.
    other than those minor details it looks great. however i have not actually tested/observed the custom timeout behavior.
    thanks jim!

@dyorgio

dyorgio commented Sep 8, 2014

Copy link
Copy Markdown

Come on guys :), merge timeout support to HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants