Stage 1A Rev Solution Code#24
Conversation
|
You should add spotless formating |
|
You're creating the mechanism sim and publishing inline in drivetrainSim but in the custructor in flywheelSim. |
|
Rename subsystems: IntakeLauncher and Feeder context: https://discord.com/channels/1516145538297368707/1516151527126073434/1517358128814100641 |
|
Updated the controls to more closely match the real kitbot. Note that the kitbot has some logic for spinning up the shooter. For simplicity's sake, I've chosen to omit that from here, though we could actually implement it in Stage 1B for the command based kitbot |
ArchdukeTim
left a comment
There was a problem hiding this comment.
Since this is 1a, should the root folder be moved to stage1a?
Maybe? I think we should just merge both PRs for 1A and refactor them after, these have been open long enough |
|
@roboteer5291 @ArchdukeTim @Adrianamm Can I get a final review on this? Would like to merge this and #34 |
roboteer5291
left a comment
There was a problem hiding this comment.
Aside from the team number, lgtm
b5680fd to
6ca05c8
Compare
For #25
Solution for Stage 1A - going to go back and strip stuff out for the starter code once this is merged.
Note that REV SparkSim is currently bugged (wpilibsuite/SystemcoreTesting#284), so we're rolling our own sim implementation for the time being. While this sim implementation doesn't support the REV APIs, it does everything it needs to do as far as Stage 1 is concerned.