fix: retry failed downloads#2688
Merged
simon04 merged 1 commit intoMay 26, 2026
Merged
Conversation
simon04
approved these changes
May 26, 2026
Contributor
simon04
left a comment
simon04
left a comment
There was a problem hiding this comment.
Amazing, thank you for implementing this workaround.
Contributor
Author
|
No worries, it looks like it was enough. It's a little hard to figure out what's wrong because it seems the bucket sometimes simply doesn't respond. I'll see if I can find out why. |
Contributor
Author
|
Rather curiously, it only needed to retry once in the latest deploy. |
Contributor
|
Deployments used to take only approx 2min in 2025-12; since then the times have steadily increased: https://github.com/freeCodeCamp/devdocs/actions/workflows/build.yml |
Contributor
Author
|
Right. We could be seeing failures more often simply because the number of requests keeps growing. Maybe. I'm not 100% sure that's the whole story, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the build retry failed downloads a couple of times.
I checked locally and it handles the failures without any obvious issues.
Ref: #2686