test(dgb): DB DGB-as-parent AuxPoW commitment binding KAT (#313 surface) [HOLD on #313]#314
Merged
Merged
Conversation
frstrtr
force-pushed
the
dgb/aux-doge-db-commitment-bind
branch
2 times, most recently
from
54836e3 to
fbfb52e
Compare
Phase DB first slice. Instantiates the templated shared aux module (#313) with the DGB parent coinbase type: doge::coin::CAuxPow<dgb::coin::Mutable- Transaction>. Proves the DB binding (1) instantiates, (2) round-trips byte-stable at the CMerkleTx and full CAuxPow layers, and (3) is wire byte-identical to the ltc default for identical commitment content -- the DGB analog of #313 named LTC acceptance gate. Fenced/test-only; consumes the shared module, modifies nothing. Registered in test/CMakeLists.txt + both build.yml allowlists. Built on the #313 branch; merge held until #313 lands in master so the binding is against the landed surface.
…e-DB binding The #313 templated aux module resolves the parent coinbase witness-strip TxParams from the PARENT type, defaulting to bitcoin_family TX_NO_WITNESS. DGB declares its own dgb::coin::TxParams, so CAuxPow<dgb::coin::Mutable- Transaction> failed to compile (bitcoin_family params cannot drive dgb SerializeTransaction). Per the #313 trait doc -- "a parent with its OWN TxParams specializes this in ITS OWN tree (never here)" -- add the DGB specialization pointing at dgb::coin::TX_NO_WITNESS, in src/impl/dgb/ only. Shared module unmodified; per-coin isolation held. DB KAT now 5/5: instantiates, round-trips byte-stable, and is wire byte-identical to the ltc default.
frstrtr
force-pushed
the
dgb/aux-doge-db-commitment-bind
branch
from
fbfb52e to
3bb1216
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase DB first slice — DGB+DOGE dual-parent (-DAUX_DOGE).
Instantiates the templated shared aux module (#313) with the DGB parent coinbase type:
doge::coin::CAuxPow<dgb::coin::MutableTransaction>. Five KATs prove the DB binding (1) instantiates, (2) round-trips byte-stable at the CMerkleTx and full CAuxPow layers, and (3) is wire byte-identical to the ltc default for identical commitment content — the DGB analog of #313 named LTC acceptance gate.Fenced / test-only: consumes the shared module, modifies nothing. Registered in test/CMakeLists.txt + both build.yml allowlists (no NOT_BUILT sentinel).
HOLD: built on the #313 branch (templated auxpow surface). Merge held until #313 lands in master so the binding is against the landed surface (per integrator UID-1851). Will rebase onto master after #313 lands.
Per-coin isolation: links ltc_coin only via the -DAUX_DOGE consumption path, same as the sibling dgb_aux_parent_coinbase_parity_test.