Skip to content

[repo-assist] perf: HtmlParser reuses CurrentTag and Content StringBuilders across tokens #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[repo-assist] perf: HtmlParser reuses CurrentTag and Content StringBuilders across tokens #1789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/FSharp.Data.Html.Core/HtmlParser.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ module internal HtmlParser =
member x.EmitSelfClosingTag() =
let name = x.CurrentTag.ToString().Trim()
let result = Tag(true, name, x.GetAttributes())
x.CurrentTag <- { Contents = StringBuilder() }
x.CurrentTag.Clear()
x.InsertionMode <- DefaultMode
x.Attributes <- []
x.Tokens <- result :: x.Tokens
Expand Down Expand Up @@ -217,7 +217,7 @@ module internal HtmlParser =
else
DefaultMode

x.CurrentTag <- { Contents = StringBuilder() }
x.CurrentTag.Clear()
x.Attributes <- []
x.Tokens <- result :: x.Tokens

Expand All @@ -228,7 +228,7 @@ module internal HtmlParser =
for c in content do
x.ConsAttrValue c

x.Content <- { Contents = StringBuilder() }
x.Content.Clear()
x.InsertionMode <- DefaultMode

member x.Emit() : unit =
Expand All @@ -252,7 +252,7 @@ module internal HtmlParser =
| DocTypeMode -> DocType content
| CDATAMode -> CData(content.Replace("<![CDATA[", "").Replace("]]>", ""))

x.Content <- { Contents = StringBuilder() }
x.Content.Clear()
x.InsertionMode <- DefaultMode

match result with
Expand Down