Skip to content

[Dependencies] Updating Meziantou.Analyzer (Code Analysis) to 3.0.109#380

Merged
dnyw4l3n13 merged 2 commits into
mainfrom
depends/update-meziantou.analyzer/3.0.109
Jun 23, 2026
Merged

[Dependencies] Updating Meziantou.Analyzer (Code Analysis) to 3.0.109#380
dnyw4l3n13 merged 2 commits into
mainfrom
depends/update-meziantou.analyzer/3.0.109

Conversation

@github-actions

Copy link
Copy Markdown

Description

How Has This Been Tested

  • All unit tests pass.
  • All integration tests pass.
  • Manual Testing:

Types of changes

  • Docs change
  • Refactoring
  • Dependency upgrade
  • Additional Unit Tests\Integration Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Removed no-longer used code

Deployment Configuration Changes

  • Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

  • I have added tests to cover my changes.
  • Unreleased section of CHANGELOG.md has been updated with details of this PR.

@github-actions github-actions Bot added the auto-pr Pull request created automatically label Jun 22, 2026
@dnyw4l3n13 dnyw4l3n13 self-assigned this Jun 23, 2026
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

CI failed with MA0032/MA0040 (Meziantou.Analyzer 3.0.109) in BotService.cs.

Fixed in e07558c — replaced CancellationToken.None with a CancellationTokenSource tied to the service lifetime: passed its Token to both ReadAllAsync and Subscribe calls, cancel it in StopAsync, and also cancel+dispose it in Dispose.

@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 23, 2026 11:50
@dnyw4l3n13 dnyw4l3n13 requested a review from a team as a code owner June 23, 2026 11:50
@dnyw4l3n13 dnyw4l3n13 enabled auto-merge June 23, 2026 11:50
credfeto and others added 2 commits June 23, 2026 11:56
MA0032/MA0040 (Meziantou.Analyzer 3.0.109) require that ReadAllAsync and
Subscribe are both called with a meaningful CancellationToken rather than
CancellationToken.None or no token. Added a CancellationTokenSource tied
to the service lifetime, passed its Token to both ReadAllAsync and Subscribe
calls (Subscribe(token) automatically disposes the subscription when
cancelled), cancel it in both StopAsync and Dispose, and removed the now-
redundant IDisposable subscription fields.
@dnyw4l3n13 dnyw4l3n13 force-pushed the depends/update-meziantou.analyzer/3.0.109 branch from e07558c to 726c8e4 Compare June 23, 2026 11:58
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Rebase onto main completed. Conflicts resolved by keeping CHANGELOG.md entries from both sides and taking the latest package versions (FunFair.Test.Source.Generator 6.3.1.2342, Meziantou.Analyzer 3.0.109, Mediator.SourceGenerator 3.0.2).

CI checks are now pending — waiting for results before proceeding.

@credfeto

Copy link
Copy Markdown
Member

Super-linter summary

Language Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

All CI checks have passed. Auto-merge is enabled and the PR will merge automatically once all branch protection requirements are satisfied.

@dnyw4l3n13 dnyw4l3n13 merged commit 22a7edd into main Jun 23, 2026
20 checks passed
@dnyw4l3n13 dnyw4l3n13 deleted the depends/update-meziantou.analyzer/3.0.109 branch June 23, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-pr Pull request created automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants