Fix segfault in poisson disk downsampling of empty point cloud#116
Open
SAY-5 wants to merge 1 commit into
Open
Fix segfault in poisson disk downsampling of empty point cloud#116SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115.
downsample_point_cloud_poisson_diskcrashes when the input point cloud has zero points. The radius path callsblue_noise_downsample, which computes grid bounds withX.colwise().minCoeff()andXs.maxCoeff(); both are undefined on a zero-row Eigen matrix, so the empty case reads out of bounds and segfaults.This returns an empty index array immediately when the input has no points, before the bounds are computed. Added a regression test for the empty-input case.