rename deprecated generic_tech to gpdk - #752
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Reviewer's GuideThis PR updates all gplugins and notebook references from the deprecated gdsfactory.generic_tech API to the newer gdsfactory.gpdk API for layers, layer stacks, simulation settings, and PDK access, without changing functional logic. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the codebase away from the deprecated gdsfactory.generic_tech module to the newer gdsfactory.gpdk API, aligning plugins, tests, and example notebooks with the updated generic PDK surface.
Changes:
- Updated notebooks to import
get_generic_pdk,LAYER, andLAYER_STACKfromgdsfactory.gpdk. - Updated multiple plugin modules to import technology constants/settings from
gdsfactory.gpdk(includinglayer_map,layer_stack, andsimulation_settings). - Updated unit tests to reference
gdsfactory.gpdkto match the new import locations.
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| notebooks/workflow_1_mzi.ipynb | Switch get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/tidy3d_00_tidy3d.ipynb | Switch LAYER_STACK/get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/sax_01_sax.ipynb | Switch get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/ray_optimiser.ipynb | Switch get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/palace_02_fullwave.ipynb | Switch LAYER/get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/palace_01_electrostatic.ipynb | Switch LAYER/get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/mode_solver_fdfd.ipynb | Switch get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/meow_01.ipynb | Switch get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/meep_02_gratings.ipynb | Switch get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/meep_01_sparameters.ipynb | Switch get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/lumerical_1_fdtd_sparameters.ipynb | Switch LAYER_STACK/get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/klayout_drc.ipynb | Switch LAYER import to gdsfactory.gpdk. |
| notebooks/klayout_dataprep.ipynb | Switch layer_map.LAYER import to gdsfactory.gpdk.layer_map. |
| notebooks/femwell_02_heater.ipynb | Switch get_generic_pdk import to gdsfactory.gpdk. |
| notebooks/fdtdz_01.ipynb | Switch LAYER/LAYER_STACK import to gdsfactory.gpdk. |
| notebooks/elmer_01_electrostatic.ipynb | Switch LAYER/get_generic_pdk import to gdsfactory.gpdk. |
| gplugins/sentaurus/sprocess.py | Switch LAYER/WAFER_STACK/get_process imports to gdsfactory.gpdk. |
| gplugins/sentaurus/sde.py | Switch LAYER/WAFER_STACK/LayerStackParameters imports to gdsfactory.gpdk. |
| gplugins/palace/tests/test_palace.py | Update test import to gdsfactory.gpdk.LAYER. |
| gplugins/palace/get_scattering.py | Switch LAYER_STACK import to gdsfactory.gpdk. |
| gplugins/palace/get_capacitance.py | Switch LAYER_STACK import to gdsfactory.gpdk. |
| gplugins/meshwell/tests/test_meshwell.py | Switch get_layer_stack import to gdsfactory.gpdk.layer_stack. |
| gplugins/meshwell/get_meshwell_cross_section.py | Switch layer_map/layer_stack imports to gdsfactory.gpdk. |
| gplugins/meshwell/get_meshwell_3D.py | Switch layer_map/layer_stack imports to gdsfactory.gpdk. |
| gplugins/lumerical/write_sparameters_lumerical.py | Switch simulation_settings import to gdsfactory.gpdk.simulation_settings. |
| gplugins/lumerical/read.py | Switch LAYER_STACK import to gdsfactory.gpdk. |
| gplugins/klayout/tests/test_dataprep_regions.py | Switch layer_map.LAYER import to gdsfactory.gpdk.layer_map. |
| gplugins/klayout/drc/write_drc.py | Switch LAYER imports to gdsfactory.gpdk. |
| gplugins/klayout/drc/check_width.py | Switch LAYER import to gdsfactory.gpdk. |
| gplugins/klayout/dataprep/regions.py | Switch LAYER import to gdsfactory.gpdk. |
| gplugins/femwell/test_mode_solver.py | Switch LAYER_STACK import to gdsfactory.gpdk. |
| gplugins/fdtdz/get_sparameters_fdtdz.py | Switch LAYER/LAYER_STACK imports to gdsfactory.gpdk. |
| gplugins/fdtdz/get_ports_fdtdz.py | Switch LAYER/LAYER_STACK imports to gdsfactory.gpdk. |
| gplugins/fdtdz/get_epsilon_fdtdz.py | Switch LAYER/LAYER_STACK imports to gdsfactory.gpdk. |
| gplugins/elmer/tests/test_elmer.py | Update test import to gdsfactory.gpdk.LAYER. |
| gplugins/elmer/get_capacitance.py | Switch LAYER_STACK import to gdsfactory.gpdk. |
| gplugins/devsim/get_simulation.py | Switch LAYER/LAYER_STACK imports to gdsfactory.gpdk. |
| gplugins/devsim/doping.py | Switch LAYER import to gdsfactory.gpdk. |
| gplugins/common/utils/tests/test_get_component_with_new_port_layers.py | Switch LAYER_STACK import to gdsfactory.gpdk. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by Sourcery
Enhancements: