Skip to content

rename deprecated generic_tech to gpdk - #752

Merged
joamatab merged 1 commit into
mainfrom
remove_generic_pdk_warnings
Aug 2, 2026
Merged

rename deprecated generic_tech to gpdk#752
joamatab merged 1 commit into
mainfrom
remove_generic_pdk_warnings

Conversation

@joamatab

@joamatab joamatab commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Enhancements:

  • Migrate imports from gdsfactory.generic_tech to gdsfactory.gpdk across plugins and notebooks to align with the updated generic PDK API and remove usage of deprecated modules.

Copilot AI review requested due to automatic review settings August 2, 2026 15:28
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@sourcery-ai

sourcery-ai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

This PR updates all gplugins and notebook references from the deprecated gdsfactory.generic_tech API to the newer gdsfactory.gpdk API for layers, layer stacks, simulation settings, and PDK access, without changing functional logic.

File-Level Changes

Change Details Files
Switch all plugin and notebook imports from deprecated generic_tech to gpdk equivalents for layers, layer stacks, wafer stacks, simulation settings, and PDK helpers.
  • Replace gdsfactory.generic_tech.layer_map.LAYER imports with gdsfactory.gpdk.layer_map.LAYER.
  • Replace gdsfactory.generic_tech.layer_stack imports (get_layer_stack, WAFER_STACK, LayerStackParameters, get_process) with gdsfactory.gpdk.layer_stack equivalents.
  • Replace gdsfactory.generic_tech module-level imports (LAYER, LAYER_STACK, get_generic_pdk) with gdsfactory.gpdk equivalents across simulation plugins and tests.
  • Update lumerical simulation settings import from gdsfactory.generic_tech.simulation_settings to gdsfactory.gpdk.simulation_settings.
  • Update all example notebooks to use gdsfactory.gpdk for layers, layer stacks, and PDK activation instead of generic_tech.
gplugins/meshwell/get_meshwell_3D.py
gplugins/meshwell/get_meshwell_cross_section.py
gplugins/sentaurus/sde.py
gplugins/klayout/drc/write_drc.py
gplugins/sentaurus/sprocess.py
gplugins/common/utils/tests/test_get_component_with_new_port_layers.py
gplugins/devsim/doping.py
gplugins/devsim/get_simulation.py
gplugins/elmer/get_capacitance.py
gplugins/elmer/tests/test_elmer.py
gplugins/fdtdz/get_epsilon_fdtdz.py
gplugins/fdtdz/get_ports_fdtdz.py
gplugins/fdtdz/get_sparameters_fdtdz.py
gplugins/femwell/test_mode_solver.py
gplugins/klayout/dataprep/regions.py
gplugins/klayout/drc/check_width.py
gplugins/klayout/tests/test_dataprep_regions.py
gplugins/lumerical/read.py
gplugins/lumerical/write_sparameters_lumerical.py
gplugins/meshwell/tests/test_meshwell.py
gplugins/palace/get_capacitance.py
gplugins/palace/get_scattering.py
gplugins/palace/tests/test_palace.py
notebooks/elmer_01_electrostatic.ipynb
notebooks/fdtdz_01.ipynb
notebooks/femwell_02_heater.ipynb
notebooks/klayout_dataprep.ipynb
notebooks/klayout_drc.ipynb
notebooks/lumerical_1_fdtd_sparameters.ipynb
notebooks/meep_01_sparameters.ipynb
notebooks/meep_02_gratings.ipynb
notebooks/meow_01.ipynb
notebooks/mode_solver_fdfd.ipynb
notebooks/palace_01_electrostatic.ipynb
notebooks/palace_02_fullwave.ipynb
notebooks/ray_optimiser.ipynb
notebooks/sax_01_sax.ipynb
notebooks/tidy3d_00_tidy3d.ipynb
notebooks/workflow_1_mzi.ipynb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the codebase away from the deprecated gdsfactory.generic_tech module to the newer gdsfactory.gpdk API, aligning plugins, tests, and example notebooks with the updated generic PDK surface.

Changes:

  • Updated notebooks to import get_generic_pdk, LAYER, and LAYER_STACK from gdsfactory.gpdk.
  • Updated multiple plugin modules to import technology constants/settings from gdsfactory.gpdk (including layer_map, layer_stack, and simulation_settings).
  • Updated unit tests to reference gdsfactory.gpdk to match the new import locations.

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.

Show a summary per file
File Description
notebooks/workflow_1_mzi.ipynb Switch get_generic_pdk import to gdsfactory.gpdk.
notebooks/tidy3d_00_tidy3d.ipynb Switch LAYER_STACK/get_generic_pdk import to gdsfactory.gpdk.
notebooks/sax_01_sax.ipynb Switch get_generic_pdk import to gdsfactory.gpdk.
notebooks/ray_optimiser.ipynb Switch get_generic_pdk import to gdsfactory.gpdk.
notebooks/palace_02_fullwave.ipynb Switch LAYER/get_generic_pdk import to gdsfactory.gpdk.
notebooks/palace_01_electrostatic.ipynb Switch LAYER/get_generic_pdk import to gdsfactory.gpdk.
notebooks/mode_solver_fdfd.ipynb Switch get_generic_pdk import to gdsfactory.gpdk.
notebooks/meow_01.ipynb Switch get_generic_pdk import to gdsfactory.gpdk.
notebooks/meep_02_gratings.ipynb Switch get_generic_pdk import to gdsfactory.gpdk.
notebooks/meep_01_sparameters.ipynb Switch get_generic_pdk import to gdsfactory.gpdk.
notebooks/lumerical_1_fdtd_sparameters.ipynb Switch LAYER_STACK/get_generic_pdk import to gdsfactory.gpdk.
notebooks/klayout_drc.ipynb Switch LAYER import to gdsfactory.gpdk.
notebooks/klayout_dataprep.ipynb Switch layer_map.LAYER import to gdsfactory.gpdk.layer_map.
notebooks/femwell_02_heater.ipynb Switch get_generic_pdk import to gdsfactory.gpdk.
notebooks/fdtdz_01.ipynb Switch LAYER/LAYER_STACK import to gdsfactory.gpdk.
notebooks/elmer_01_electrostatic.ipynb Switch LAYER/get_generic_pdk import to gdsfactory.gpdk.
gplugins/sentaurus/sprocess.py Switch LAYER/WAFER_STACK/get_process imports to gdsfactory.gpdk.
gplugins/sentaurus/sde.py Switch LAYER/WAFER_STACK/LayerStackParameters imports to gdsfactory.gpdk.
gplugins/palace/tests/test_palace.py Update test import to gdsfactory.gpdk.LAYER.
gplugins/palace/get_scattering.py Switch LAYER_STACK import to gdsfactory.gpdk.
gplugins/palace/get_capacitance.py Switch LAYER_STACK import to gdsfactory.gpdk.
gplugins/meshwell/tests/test_meshwell.py Switch get_layer_stack import to gdsfactory.gpdk.layer_stack.
gplugins/meshwell/get_meshwell_cross_section.py Switch layer_map/layer_stack imports to gdsfactory.gpdk.
gplugins/meshwell/get_meshwell_3D.py Switch layer_map/layer_stack imports to gdsfactory.gpdk.
gplugins/lumerical/write_sparameters_lumerical.py Switch simulation_settings import to gdsfactory.gpdk.simulation_settings.
gplugins/lumerical/read.py Switch LAYER_STACK import to gdsfactory.gpdk.
gplugins/klayout/tests/test_dataprep_regions.py Switch layer_map.LAYER import to gdsfactory.gpdk.layer_map.
gplugins/klayout/drc/write_drc.py Switch LAYER imports to gdsfactory.gpdk.
gplugins/klayout/drc/check_width.py Switch LAYER import to gdsfactory.gpdk.
gplugins/klayout/dataprep/regions.py Switch LAYER import to gdsfactory.gpdk.
gplugins/femwell/test_mode_solver.py Switch LAYER_STACK import to gdsfactory.gpdk.
gplugins/fdtdz/get_sparameters_fdtdz.py Switch LAYER/LAYER_STACK imports to gdsfactory.gpdk.
gplugins/fdtdz/get_ports_fdtdz.py Switch LAYER/LAYER_STACK imports to gdsfactory.gpdk.
gplugins/fdtdz/get_epsilon_fdtdz.py Switch LAYER/LAYER_STACK imports to gdsfactory.gpdk.
gplugins/elmer/tests/test_elmer.py Update test import to gdsfactory.gpdk.LAYER.
gplugins/elmer/get_capacitance.py Switch LAYER_STACK import to gdsfactory.gpdk.
gplugins/devsim/get_simulation.py Switch LAYER/LAYER_STACK imports to gdsfactory.gpdk.
gplugins/devsim/doping.py Switch LAYER import to gdsfactory.gpdk.
gplugins/common/utils/tests/test_get_component_with_new_port_layers.py Switch LAYER_STACK import to gdsfactory.gpdk.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@joamatab joamatab added the documentation Improvements or additions to documentation label Aug 2, 2026
@joamatab joamatab changed the title rename deprected geenric_tech to gpdk rename deprected generic_tech to gpdk Aug 2, 2026
@joamatab joamatab changed the title rename deprected generic_tech to gpdk rename deprecated generic_tech to gpdk Aug 2, 2026
@joamatab
joamatab merged commit 41bb7ff into main Aug 2, 2026
27 of 30 checks passed
@joamatab
joamatab deleted the remove_generic_pdk_warnings branch August 2, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants