-
Notifications
You must be signed in to change notification settings - Fork 8
chore: publish Quickstarts for SDK version 5.1.0 #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alyssa Evans (alycda)
wants to merge
1
commit into
main
Choose a base branch
from
quickstart-publish/5.1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,7 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Copy this file from ".env.sample" to ".env", then fill in these values | ||
| # A Ditto AppID and Playground token can be obtained from https://portal.ditto.live | ||
| DITTO_APP_ID="" | ||
| DITTO_PLAYGROUND_TOKEN="" | ||
| DITTO_AUTH_URL="" | ||
| DITTO_WEBSOCKET_URL="" | ||
| # A Ditto Database ID and development token can be obtained from https://portal.ditto.live | ||
| DITTO_DATABASE_ID="" | ||
| DITTO_DEVELOPMENT_TOKEN="" | ||
| DITTO_SERVER_URL="" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Line-ending policy for the published Quickstart apps. | ||
| # | ||
| # The publish step (scripts/ci/quickstart/publish_quickstart.sh) exports this | ||
| # subtree with `git archive HEAD:quickstart`, which resolves .gitattributes | ||
| # relative to THIS directory. Without a .gitattributes here, the monorepo-root | ||
| # .gitattributes EOL rules are not applied to the published output, so every | ||
| # file is exported with LF -- dropping the CRLF that Windows batch files | ||
| # require. These rules are a stricter LF-forcing variant of the root policy | ||
| # (a blanket `eol=lf` rather than the root's platform-dependent `text=auto`, | ||
| # plus an explicit `*.cmd` rule) so the published getditto/quickstart repo | ||
| # (and this subtree) get deterministic, convention-correct line endings. | ||
|
|
||
| # Normalize all text to LF in the repository and on checkout/export | ||
| # (matches the repo-root .editorconfig `end_of_line = lf`). | ||
| * text=auto eol=lf | ||
|
|
||
| # Windows batch/command scripts require CRLF for cmd.exe. | ||
| *.bat text eol=crlf | ||
| *.cmd text eol=crlf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| CLAUDE.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2 —
seed-ditto-documentaction inputs were renamed, but its 5 CI callers were not updated.This action now requires
ditto-app-idandditto-development-token(and madeditto-api-urloptional), but the following workflow steps still pass the removedditto-api-key:input and never supply the new required ones:.github/workflows/cpp-tui-ci.yml:95.github/workflows/dotnet-tui-ci.yml:99.github/workflows/dotnet-winforms-ci.yml:95.github/workflows/javascript-tui-ci.yml:104.github/workflows/rust-tui-ci.yml:121Composite actions fail hard on missing required inputs, so each of these integration-test jobs will fail at this step regardless of the broader env-var rename (see general PR comment on the env-var mismatch).
Posted via
/pr-post-review-findings, from the review above.