Skip to content

fix(list): warn when pagination is not a selectable page size #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markdumay merged 1 commit into from
Jul 30, 2026
Merged

fix(list): warn when pagination is not a selectable page size #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions component-library/components/list/list.hugo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,26 @@
{{ end }}

{{ $pagination := .pagination | default 10 }}

{{/* Warn when `pagination` is not one of the per-page options the
datatable will offer. The control renders its own first option
while the table pages at the requested size, so the two silently
disagree — visible only in a browser. Skipped when the author
supplies their own option list via `pagination-select`. */}}
{{ $paginationSelect := or .pagination_select (index . "pagination-select") }}
{{ if and .paginate (not $paginationSelect) }}
{{ $permitted := slice 5 10 20 50 }}
{{ if not (in $permitted $pagination) }}
{{ partial "utilities/LogWarn.html" (dict
"partial" "component-library/components/list/list.hugo.html"
"warnid" "warn-invalid-pagination"
"msg" "Invalid pagination"
"details" (printf "pagination is %v, which is not one of %v; the per-page control will show its first option instead. Pick a permitted value or set 'pagination-select'." $pagination (delimit $permitted ", "))
"file" $page.File
)}}
{{ end }}
{{ end }}

{{ $paginate := and .paginate (gt (len $pages) $pagination) }}
{{ $sortable := and .sortable (gt (len $pages) 1) }}
{{ $searchable := and .searchable (gt (len $pages) 1) }}
Expand Down