fix(datatables): keep the per-page control in sync with perPage

[markdumay]

The defect

perPage was passed straight to simple-datatables without being checked against perPageSelect. When the value is not one of the offered options, the select falls back to rendering its first entry while the table pages at the requested size — so the control and the behaviour disagree, and nothing signals it.

The reader sees "5" above a page of 25 rows. The only way to notice is to count them.

Measured on a real site with perPage: 25 against the default options:

data-table-paging-option-perPage = "25"
select.value                     = "5"        <- first option, not 25
visible tbody rows               = 25
select options                   = 5, 10, 20, 50, All

The fix

Insert the value into the option list. That honours the author's intent and makes the control show what is actually happening:

before   select "5",  25 rows, options 5/10/20/50/All
after    select "25", 25 rows, options 5/10/20/25/50/All

Of the three available outcomes — inject, warn and fall back, or render a mismatched value — the last is the worst, because it is silent. Injecting is closest to intent, since perPage is an explicit request.

Details

The value lands in sorted position among the numeric entries, so "All" stays last. Entries may be a bare number or a [label, value] pair (that is how "All" carries -1), so the comparison reads the value in either shape and the sort ignores non-positive values.

A value already present is untouched: perPage: 10 still yields 5/10/20/50/All with the select on 10 and no injection.

Related

A build-time counterpart shipped in mod-blocks#185, which warns at Hugo time when a list block's pagination is not a selectable size. That catches the common authoring path early but cannot cover callers reaching this module directly, or a custom perPageSelect — hence this runtime fix as well.

Checks

pnpm test passes. Both cases exercised in a browser on a real 106-row table.

[markdumay]

🎉 This PR is included in version 4.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀