fix(arguments): correct the cover argument description - #360
Merged
Conversation
The shared `cover` argument was documented as "rendered fullscreen", which is rendered verbatim into the generated argument tables for every block that accepts it. A cover section is 88vh, not 100vh, so the description promised a full viewport that the theme never delivers. Describe the real behavior and name the two site settings that control it. Refs: gethinode/hinode#2107 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
🎉 This PR is included in version 6.8.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fix for gethinode/hinode#2107.
Problem
data/structures/_arguments.ymldescribed the sharedcoverargument as:This string is rendered verbatim into the generated argument tables for every block that accepts
cover— hero, about, featured, cards, panels, cta, faq, and a dozen more. A cover section is 88vh, capped at 1024px on large viewports, so the description promised a full viewport the theme never delivers. It was the third of three places making that claim, alongside the hero docs and the block docs prose.Change
Describe the real behavior, say why it falls short of 100vh, and name the two site settings that control it.
Typed
fixrather thandocsso it releases and downstream modules can pick it up.Golden tests pass (14 groups).
Related
main.sectionHeight/main.maxSectionHeightcoverflag into the hero body partial🤖 Generated with Claude Code