Skip to content

fix(event): correctly parse project/event-id in view command #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix(event): correctly parse project/event-id in view command #1263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/commands/event/view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,17 @@ function parseSingleArg(arg: string): ParsedPositionalArgs {
issueShortId: beforeSlash,
};
}

// "project/EVENT-ID" → project slug + hex event ID.
// e.g., "my-project/abc123def456abc123def456abc123de"
// Must be checked before parseSlashSeparatedArg, which throws ContextError
// for any single-slash arg, assuming it's "org/project" with a missing ID.
if (afterSlash && HEX_ID_RE.test(normalizeHexId(afterSlash))) {
return {
eventId: normalizeHexId(afterSlash),
targetArg: beforeSlash,
};
}
}

const { id: eventId, targetArg } = parseSlashSeparatedArg(
Expand Down
Loading