chore(lint): prevent generic isRecord guards#1272
Draft
betegon wants to merge 1 commit into
Draft
Conversation
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 93.75%. Project has 5501 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 81.69% 81.65% -0.04%
==========================================
Files 426 427 +1
Lines 29909 29973 +64
Branches 19433 19497 +64
==========================================
+ Hits 24431 24472 +41
- Misses 5478 5501 +23
- Partials 2035 2037 +2Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents new generic
isRecordtype guards from being added undersrc/. The existing helpers now use local, shape-specific names so each call site states what runtime shape it actually needs.Changes
isRecorddeclarations without blocking unrelated boolean variablesTest Plan
pnpm run lintpnpm exec tsc --noEmitpnpm run check:depspnpm run check:errorspnpm run test:unit: 8,519 passed; 9 unrelated local failures remain (six timezone-sensitive assertions pass withTZ=UTC, two bash simulations require newer than macOS bash 3.2, and one existing self-hosted wizard test fails independently)