fix(local): warn when the event stream cannot be attached - #1343
Merged
Conversation
consumeSSE() gave up silently when the very first connection attempt failed. /health can answer 200 while /stream does not — an unrelated service squatting on the port, or the server going away between the two requests — and in that case nothing was ever printed again. That is worst in `local run`, which keeps the child process alive: the user saw 'Connected to existing server', then no events for the rest of the session with no explanation. Emit a warning before giving up, and log the 200-with-no-body case that was also returning silently. Addresses the review comment on #1342. Co-authored-by: Aditya Mathur <MathurAditya724@users.noreply.github.com>
MathurAditya724
enabled auto-merge (squash)
August 3, 2026 06:43
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consumeSSE() gave up silently when the very first connection attempt failed. /health can answer 200 while /stream does not — an unrelated service squatting on the port, or the server going away between the two requests — and in that case nothing was ever printed again.
That is worst in
local run, which keeps the child process alive: the user saw 'Connected to existing server', then no events for the rest of the session with no explanation. Emit a warning before giving up, and log the 200-with-no-body case that was also returning silently.Addresses the review comment on #1342.