feat(node): use ioredis tracing channels#21187
Open
logaretm wants to merge 1 commit into
Open
Conversation
Co-Authored-By: GPT-5 Codex <codex@openai.com>
Contributor
size-limit report 📦
|
logaretm
requested review from
JPeer264,
andreiborza and
isaacs
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 93cbcbb. Configure here.
| ); | ||
| setupConnectChannel(CHANNEL_REDIS_CONNECT); | ||
| setupCommandChannel<IORedisCommandData>(CHANNEL_IOREDIS_COMMAND, data => data.args); | ||
| setupBatchChannel<IORedisBatchData>(CHANNEL_IOREDIS_BATCH, () => 'MULTI'); |
There was a problem hiding this comment.
Subscription to nonexistent ioredis:batch channel is dead code
Low Severity
ioredis 5.11 only publishes two tracing channels: ioredis:command and ioredis:connect. There is no ioredis:batch channel — batch metadata (batchMode, batchSize) is included in the ioredis:command context instead. The setupBatchChannel call for CHANNEL_IOREDIS_BATCH, the IORedisBatchData interface, and the corresponding unit tests all exercise a code path that will never be triggered in production, creating a false impression that batch operations receive separate wrapping spans for ioredis.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 93cbcbb. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ioredis5.11 released tracing channels so we can start using them in the integration, I followed the same strategy we established withredisclient by limiting the patching to older releases and subscribing anyways which will be inert except for newer releases.I added similar tests as well to ensure both dc and non-dc paths still work.
This is not to be confused with the
redisclient, there is two of them,redisandioredis, the latter being older but more popular.