feat(billing): protos for master-dataclass promotion#344
Draft
armcknight wants to merge 3 commits into
Draft
Conversation
Promotes several dataclass prototypes already in use on getsentry master
to real protos. No behavioral change on its own -- this is the sentry-protos
side of the getsentry-side promotion PR.
Included:
- ``charge.proto`` -- adds ``PlatformCharge.date_added_st`` (mirrors
``PlatformRefund.date_added_st`` so mixed charge+refund timelines
can sort off a single time axis).
- ``endpoint_list_charges_for_invoice_ids.proto`` (new) -- used by
``ChargeService.list_charges_for_invoice_ids`` on master.
- ``endpoint_list_charges_for_organization.proto`` (new) -- used by
``ChargeService.list_charges_for_organization`` on master.
- ``endpoint_get_invoice_guids_for_ids.proto`` (new) -- used by
``ContractService.get_invoice_guids_for_ids`` on master.
- ``endpoint_start_manual_payment.proto`` (new) -- used by
``ContractService.start_manual_payment`` on master (added in
getsentry/getsentry#20790).
Split out from the original combined branch. The remaining Pay-Now-loop
protos (release_manual_payment_lock, modifications to handle_charge_succeeded /
capture_charge / mark_invoice_paid) live on a separate branch that
partners with getsentry/getsentry#20833.
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
…rotos Field-level context moved to PR #344's description; kept short one-line comments for the semantic hint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes several dataclass prototypes already in use on getsentry master to real protos. Companion to a getsentry-side promotion PR (getsentry/getsentry#20887) that will bump the
sentry-protospin once this lands.Included
charge.proto— addsPlatformCharge.date_added_st(mirrorsPlatformRefund.date_added_stso mixed charge+refund timelines can sort off a single time axis).endpoint_list_charges_for_invoice_ids.proto(new) — used byChargeService.list_charges_for_invoice_idson master.endpoint_list_charges_for_organization.proto(new) — used byChargeService.list_charges_for_organizationon master.endpoint_get_invoice_guids_for_ids.proto(new) — used byContractService.get_invoice_guids_for_idson master.endpoint_start_manual_payment.proto(new) — used byContractService.start_manual_paymenton master (added in getsentry/getsentry#20790).Context
Split out from an earlier combined branch. The remaining Pay-Now-loop protos (
release_manual_payment_lock+ modifications tohandle_charge_succeeded/capture_charge/mark_invoice_paid) live on branchandrewmcknight/billing-pay-now-loop-close-protosand partner with getsentry/getsentry#20833.