feat(billing): Add package retention defaults#369
Draft
dashed wants to merge 1 commit into
Draft
Conversation
Expose complete category-level retention defaults on PackageConfig and cover repeated-field serialization in Python and generated Rust bindings.
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #368 and exposes its complete category-level retention policies through
PackageConfig.retention_defaults. The repeated field is additive and remains empty until GetSentry package definitions populate it; this PR does not make retention authoritative or add package validation.The field uses tag 14 because another active package-schema branch has already claimed tag 13 for
is_sponsored. Python and Rust round-trip coverage verifies multiple category policies, concrete and inherited downsampled retention, and a standard-only category with no distinct downsampled representation.Package population, accepted-category validation, alias conflict checks, and the legacy package compatibility proof remain follow-up work in GetSentry.