feat(billing): add effective retention endpoint#371
Draft
dashed wants to merge 1 commit into
Draft
Conversation
Add the GetRetentions endpoint proto for the platform effective-retention
resolver: GetRetentionsRequest{organization_id} and GetRetentionsResponse
carrying per-category resolved retention (EffectiveDataCategoryRetention with
concrete standard_days and optional downsampled_days), a contract_present flag,
the source retention policy revision, and the category-less standard/downsampled
scalars. Effective settings carry no inheritance sentinel -- inherit-standard is
resolved to concrete days by the resolver. No service declaration, mirroring
endpoint_get_quotas.proto. Python and Rust round-trip coverage.
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #370. Adds the endpoint proto for the platform effective-retention resolver (Alternative D, stage B4) — the read side that will resolve package defaults + contract overrides into concrete effective retention.
New
services/quotas/v1/endpoint_get_retentions.proto(noservicedeclaration, mirroringendpoint_get_quotas.proto):Key distinction from the raw retention messages (#368/#370):
EffectiveRetentionSettingscarries concrete days with no inheritance sentinel — the resolver normalizesinherit_standardto concrete standard days, so the effective endpoint never exposes the raw sentinel.downsampled_daysis absent (not zero) for standard-only categories.The resolver that populates this is the follow-up GetSentry PR. Python and Rust round-trip coverage.