Skip to content

ref: Use top-level trace_lifecycle and ignore_spans options in tests#6855

Merged
sentrivana merged 1 commit into
masterfrom
ivana/use-non-experimental-span-streaming-options
Jul 21, 2026
Merged

ref: Use top-level trace_lifecycle and ignore_spans options in tests#6855
sentrivana merged 1 commit into
masterfrom
ivana/use-non-experimental-span-streaming-options

Conversation

@sentrivana

@sentrivana sentrivana commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaced all _experiments={"trace_lifecycle": ...} with top-level trace_lifecycle=... across 77 test files
  • Replaced _experiments={"ignore_spans": ...} with top-level ignore_spans=...
  • Kept backwards-compat tests in test_client.py and test_span_streaming.py that specifically verify _experiments still works and that top-level takes precedence

These options have been moved from `_experiments` to top-level SDK options.
Update all test files to use the non-experimental form. Backwards-compat
tests that verify `_experiments` still works are intentionally left as-is.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sentrivana
sentrivana marked this pull request as ready for review July 21, 2026 08:44
@sentrivana
sentrivana requested a review from a team as a code owner July 21, 2026 08:44
@sentrivana sentrivana changed the title ref: Use top-level trace_lifecycle and ignore_spans options in tests ref: Use top-level trace_lifecycle and ignore_spans options in tests Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

91914 passed | ⏭️ 6302 skipped | Total: 98216 | Pass Rate: 93.58% | Execution Time: 316m 54s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2476 uncovered lines.
✅ Project coverage is 89.69%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.69%    89.69%        —%
==========================================
  Files          193       193         —
  Lines        24007     24007         —
  Branches      8342      8342         —
==========================================
+ Hits         21530     21531        +1
- Misses        2477      2476        -1
- Partials      1386      1385        -1

Generated by Codecov Action

@sentrivana
sentrivana merged commit b5171b7 into master Jul 21, 2026
141 checks passed
@sentrivana
sentrivana deleted the ivana/use-non-experimental-span-streaming-options branch July 21, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants