fix(charts): Stabilize ChartComponent reference in EventsChart#120037
Open
sentry[bot] wants to merge 1 commit into
Open
fix(charts): Stabilize ChartComponent reference in EventsChart#120037sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
static-component-definitionsviolation flagged by the React Compiler instatic/app/components/charts/eventsChart.tsx.Problem:
The
ChartComponentused in theChartcomponent was being derived via an inline functiongetChartComponent()called directly within the render body. This meant thatChartComponentreceived a new identity on every render, causing React to unmount and remount the component subtree unnecessarily, and preventing compiler optimizations.Solution:
The
getChartComponent()helper function has been removed. The logic to determine the correct chart component (e.g.,BarChart,LineChart,AreaChart) is now encapsulated within auseMemohook. This ensures thatChartComponentmaintains a stable reference across renders, only re-evaluating when its dependencies (chartComponent,showDaily,timeseriesData.length,forceChartType,yAxis) change. This resolves thestatic-component-definitionsissue and allows for proper React Compiler optimization.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-35D
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.