Skip to content

fix(structuredEventData): Remove inline Wrapper component in RecursiveStructuredData#120038

Merged
ryan953 merged 1 commit into
masterfrom
seer/fix/remove-inline-wrapper-recursive-structured-data
Jul 20, 2026
Merged

fix(structuredEventData): Remove inline Wrapper component in RecursiveStructuredData#120038
ryan953 merged 1 commit into
masterfrom
seer/fix/remove-inline-wrapper-recursive-structured-data

Conversation

@sentry

@sentry sentry Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor
The `Wrapper` component in `static/app/components/structuredEventData/recursiveStructuredData.tsx` was defined inside the `RecursiveStructuredData` function component. This caused it to be re-created on every render, violating the `static-component-definitions` convention and preventing React Compiler optimizations.

This change removes the Wrapper component definition and inlines its functionality (prepending formattedObjectKey to its children) directly at each return site using a Fragment.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes CODING-CONVENTIONS-364

Comment @sentry <feedback> on this PR to have Autofix iterate on the changes.

@ryan953 ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jul 20, 2026
@ryan953
ryan953 enabled auto-merge (squash) July 20, 2026 19:33
@ryan953
ryan953 merged commit 7ee0077 into master Jul 20, 2026
92 of 93 checks passed
@ryan953
ryan953 deleted the seer/fix/remove-inline-wrapper-recursive-structured-data branch July 20, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant