perf(jest): Mock root ECharts imports#120049
Merged
Merged
Conversation
The existing mapper only catches ECharts subpaths, so root imports still load and transform the full package. Match the root export too and fill in the small API surface tests use.\n\nThe focused chart suite drops from a 4.530s median to 4.125s with Jest's cache disabled, about 9% faster.\n\nCo-Authored-By: Codex <noreply@openai.com>
scttcper
marked this pull request as ready for review
July 20, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ECharts Jest mapper only matched subpaths, so root imports still loaded and transformed the real package. Match both the package root and subpaths to the lightweight mock, and expose the small root API surface tests use.
Benchmarking
useChartXRangeSelection.spec.tsxover five cache-disabled runs:This helps any Jest suite that reaches a root ECharts import by avoiding the real module work.