Skip to content

feat(issues): Remove fake auto-resolution#120153

Open
scttcper wants to merge 2 commits into
masterfrom
scttcper/remove-virtual-resolution
Open

feat(issues): Remove fake auto-resolution#120153
scttcper wants to merge 2 commits into
masterfrom
scttcper/remove-virtual-resolution

Conversation

@scttcper

@scttcper scttcper commented Jul 20, 2026

Copy link
Copy Markdown
Member

Remove the fake read-time auto-resolution status and the workarounds it required. Issues pending auto-resolution now stay unresolved until the background task persists the transition. The auto-resolution task is being adjusted from 1 hour intervals to 10 minutes in #120149

some history:

  • Before 2016, auto-resolution was not persisted. The model and serializer inferred it from last_seen and the project's resolve age, returning resolved while the database row was still unresolved.
  • statusDetails.autoResolved was added in 2015 for #2341 so the UI could explain why unresolve did not stick and disable that action.
  • The persisted auto-resolve task arrived in 2016 with the stated goal of removing the obscure magic from the code and UI.
  • The fake path stayed around alongside the task, requiring extra filtering after issue serialization and special regression handling. #102160 added another exception in 2025 after manually unresolved issues were immediately shown as resolved again.

Refs https://linear.app/getsentry/issue/ID-1710

Auto-resolution is persisted by the background task now, but model and serializer paths still inferred resolved state from last_seen.

Remove that legacy status override along with the search and regression workarounds it required.

Co-Authored-By: Codex <noreply@openai.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 20, 2026
@scttcper scttcper changed the title ref(issues): Remove virtual auto-resolution ref(issues): Remove fake auto-resolution Jul 20, 2026
@linear-code

linear-code Bot commented Jul 20, 2026

Copy link
Copy Markdown

ID-1710

@scttcper scttcper changed the title ref(issues): Remove fake auto-resolution feat(issues): Remove fake auto-resolution Jul 20, 2026
Remove tests that only assert the deleted inference stays deleted, plus inert resolve_age setup copied into event lookup tests.

Co-Authored-By: Codex <noreply@openai.com>
@scttcper
scttcper marked this pull request as ready for review July 20, 2026 23:17
@scttcper
scttcper requested review from a team as code owners July 20, 2026 23:17
@scttcper
scttcper requested a review from wedamija July 20, 2026 23:17

@wedamija wedamija left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I can't believe this was replicated in so many places. Nice clean up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants