fix(taskbroker): Replace worker_map Default Instead of Merging#756
Merged
george-sentry merged 4 commits intoJul 16, 2026
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
evanh
approved these changes
Jul 16, 2026
|
|
||
| for (application, endpoint) in config.worker_map.clone() { | ||
| let worker = match Worker::connect(config.clone(), endpoint).await { | ||
| let worker = match Worker::connect(config.clone(), endpoint.clone()).await { |
Member
There was a problem hiding this comment.
This is a good point, can we have the startup fail if the worker map is empty?
Member
Author
There was a problem hiding this comment.
Yepp, I added a validate attribute to the worker_map field to make sure it has at least one entry. Also, I changed the code to use a default when the user doesn't provide anything. But this time, the user's worker_map replaces the default instead of merging with it.
enochtangg
approved these changes
Jul 16, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 779da43. Configure here.
george-sentry
changed the title
worker_map Defaultworker_map Default Instead of Merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, the Seer push taskbroker was getting a
connection refusederror when trying to reach the taskworker service. After some deep investigation, I found that Figment is very silly. Instead of replacingworker_mapwith whatever the user provides, it merges it.So if you provide
TASKBROKER_WORKER_MAP={seer=foo}, its value will be{sentry=http://127.0.0.1:50052, seer=foo}rather than just{seer=foo}. I strongly suspect that is the cause.I have changed the code to replace
worker_mapwith whatever the user provides, falling back on the previous default if the user doesn't provide anything.