ref(o11y): Support SDK configured with the streaming trace lifecycle#757
Conversation
| readme = "README.md" | ||
| dependencies = [ | ||
| "sentry-arroyo>=2.41.0", | ||
| "sentry-sdk[http2]>=2.43.0", |
There was a problem hiding this comment.
We should bump the minimum to the latest, so Span Streaming is fully available.
There was a problem hiding this comment.
this is a library, we should not arbitrarily restrict its version ranges unless actually required
There was a problem hiding this comment.
It is required, hence I raised it 😄
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 213edcd. Configure here.
No it doesn't on the streaming trace lifecycle path. Would it be possible to remove the attributes? We could also put in |
😅 yeah that trimming is in the sdk for a reason. i guess we could remove the attributes? kinda sad. some of them can be 40 MB large |
|
I've kept the transaction-based logic the same and do not attach the attributes in the streaming trace lifecycle now. I'd have to take a closer look at what's in |
|
well, i would not want to maintain this logic in taskbroker, so i think it's fine |

Use the
sentry_sdk.tracesAPI when the streaming lifecycle is enabled. The transaction-based API should no-op and warns when the lifecycle is enabled (and does with an up-to-datesentry-sdk, the fact that it didn't previously no-op contributed to an incident).Bump the minimum
sentry-sdkversion to 2.52.0 since that's the first version in whichScope. set_custom_sampling_context()is a classmethod.Closes #761