ref(o11y): Remove redundant span status assignment#759
Merged
Conversation
alexander-alderman-webb
marked this pull request as ready for review
July 21, 2026 13:19
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 43ec0e3. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
evanh
approved these changes
Jul 21, 2026
evanh
reviewed
Jul 21, 2026
| task_func(*args, **kwargs) | ||
| transaction.set_status(SPANSTATUS.OK) | ||
| except Exception: | ||
| transaction.set_status(SPANSTATUS.INTERNAL_ERROR) |
Member
There was a problem hiding this comment.
Where is this being set in the new code? Does the sdk do this automatically?
Contributor
Author
There was a problem hiding this comment.
It's in the SDK. It's set in Span.__exit__() (or StreamedSpan.__exit__()) in the SDK (invoked when the context manager exits). The link to the former is below.
alexander-alderman-webb
changed the base branch from
webb/add-init-to-tests
to
main
July 22, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
with sentry_sdk.start_transaction()andwith sentry_sdk.start_span()context managers set the span status tointernal_errorwhen they exit with an exception. Explicitly catchingExceptionand setting the status is therefore redundant (since theexcept:block re-raised within the context manager's scope).Changed so that we do not add complexity when branching for span streaming.