Skip to content

fix: Row Detail newly expanded row shouldn't be re-rendered#2667

Merged
ghiscoding merged 2 commits into
masterfrom
bugfix/row-detail-expanded-rendered
Jul 25, 2026
Merged

fix: Row Detail newly expanded row shouldn't be re-rendered#2667
ghiscoding merged 2 commits into
masterfrom
bugfix/row-detail-expanded-rendered

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Row Detail keep references of 2 internal Set list (_expandedRowIds and _renderedViewportRowIds) of item ids to know if a Row Detail must be re-rendered or not. However when expanding a new row, it was only adding it to the _expandedRowIds not the _renderedViewportRowIds Set, and this could cause some issues. I couple replicate the bug when opening a Row Detail with an inner grid, then adding a filter in that inner grid, then click on the outer main grid browser scroll and this was causing a re-render (and filters clared) in some cases event though the grid was still visible and never left the visible viewport range... so it makes sense to add it to the _renderedViewportRowIds when we expand a new row and not expect it to be re-rendered when scrolling by a few pixels

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (aaf7178) to head (1536343).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2667   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         200      200           
  Lines       25353    25354    +1     
  Branches     8968     8968           
=======================================
+ Hits        25353    25354    +1     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Jul 25, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2667

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2667

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2667

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2667

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2667

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2667

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2667

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2667

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2667

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2667

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2667

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2667

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2667

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2667

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2667

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2667

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2667

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2667

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2667

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2667

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2667

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2667

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2667

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2667

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2667

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2667

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2667

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2667

commit: 1536343

@ghiscoding
ghiscoding merged commit daeaf31 into master Jul 25, 2026
14 checks passed
@ghiscoding
ghiscoding deleted the bugfix/row-detail-expanded-rendered branch July 25, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant