Skip to content

serve: reject valueless promisor-remote capability #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
newren wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

serve: reject valueless promisor-remote capability #2199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions serve.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ static int promisor_remote_advertise(struct repository *r,
static void promisor_remote_receive(struct repository *r,
const char *remotes)
{
if (!remotes)
die("promisor-remote capability requires an argument");

mark_promisor_remotes_as_accepted(r, remotes);
}

Expand Down
11 changes: 11 additions & 0 deletions t/t5701-git-serve.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,17 @@ test_expect_success 'request invalid capability' '
test_grep "unknown capability" err
'

test_expect_success 'promisor-remote capability requires an argument' '
test-tool pkt-line pack >in <<-EOF &&
command=ls-refs
object-format=$(test_oid algo)
promisor-remote
0000
EOF
test_must_fail test-tool serve-v2 --stateless-rpc 2>err <in &&
test_grep "promisor-remote capability requires an argument" err
'

test_expect_success 'request with no command' '
test-tool pkt-line pack >in <<-EOF &&
agent=git/test
Expand Down
Loading