Skip to content

Always make docker_registry registries available#4024

Merged
mbg merged 1 commit into
mainfrom
mbg/private-registry/make-docker-available
Jul 21, 2026
Merged

Always make docker_registry registries available#4024
mbg merged 1 commit into
mainfrom
mbg/private-registry/make-docker-available

Conversation

@mbg

@mbg mbg commented Jul 20, 2026

Copy link
Copy Markdown
Member

A similar change as in #4000, which makes docker_registry registries always available to the workflow. The CLI can use Docker-style registries for custom query packs.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg
mbg requested a review from mario-campos July 20, 2026 18:58
@mbg mbg self-assigned this Jul 20, 2026
@mbg
mbg requested a review from a team as a code owner July 20, 2026 18:58
Copilot AI review requested due to automatic review settings July 20, 2026 18:58
@github-actions github-actions Bot added the size/XS Should be very easy to review label Jul 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

Makes Docker registry credentials available across all language workflows so the CodeQL CLI can access custom query packs.

Changes:

  • Adds docker_registry to always-enabled registry types.
  • Extends tests across Actions and all built-in languages.
Show a summary per file
File Description
src/start-proxy.ts Always enables Docker registry credentials.
src/start-proxy.test.ts Tests Docker credentials as always enabled.
lib/entry-points.js Generated output; excluded by policy.

Review details

Files excluded by content exclusion policy (1)
  • lib/entry-points.js
  • Files reviewed: 2/3 changed files
  • Comments generated: 0
  • Review effort level: Medium

@mario-campos mario-campos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellisonantoniafelicia-star

This comment has been minimized.

@mbg
mbg added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 69fd9e9 Jul 21, 2026
226 checks passed
@mbg
mbg deleted the mbg/private-registry/make-docker-available branch July 21, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants