C#: Update Roslyn and other pinned depenencies.#21893
Draft
michaelnebel wants to merge 3 commits into
Draft
Conversation
michaelnebel
force-pushed
the
cshar/updateroslyn
branch
from
a2b806b to
7f2fb2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of interesting things.
It appears that the decoder compiler argument from the
optionswasn't respected (there is an error that the code page is not installed) prior to thus change. However, with the Roslyn update windows-1252 is added as an Emit option for the CSharp Compilation in the extractor.If I decode the
SBCS.csin VS-Code using Windows-1252, then it is the characterand I believe it is the
0x92byte - which isU+FFFDunder the default UTF-8 decoding. That is,