Ruby: Address testFailures in inline expectations tests (part 3)#22105
Open
geoffw0 wants to merge 2 commits into
Open
Ruby: Address testFailures in inline expectations tests (part 3)#22105geoffw0 wants to merge 2 commits into
geoffw0 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a Ruby ActiveSupport inline-expectations dataflow library test to clear the testFailures section by marking a known unexpected value-flow result as spurious.
Changes:
- Adds a
SPURIOUSinline-expectation marker for themulti.solesink case inhash_extensions.rb. - Updates the generated
.expectedfile offsets to reflect the inserted line and to remove thetestFailuresentry.
Show a summary per file
| File | Description |
|---|---|
| ruby/ql/test/library-tests/frameworks/active_support/hash_extensions.rb | Adds a SPURIOUS inline-expectation marker for the known unexpected flow through sole. |
| ruby/ql/test/library-tests/frameworks/active_support/ActiveSupportDataFlow.expected | Regenerates expected edges/nodes and removes the testFailures entry for the sole case. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hvitved
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotations should always be updated so that the
testFailuressection of the.expectedfile is empty.@hvitved apologies, I missed this one case in the two initial PRs. It's just a missing
SPURIOUStag.