feat(issue-fields): expose fullDatabaseId (BigInt) in list_issue_fields#2526
Open
iulia-b wants to merge 1 commit into
Open
feat(issue-fields): expose fullDatabaseId (BigInt) in list_issue_fields#2526iulia-b wants to merge 1 commit into
iulia-b wants to merge 1 commit into
Conversation
- Add DatabaseID (int64) to IssueField struct, populated from fullDatabaseId BigInt scalar (returned as string) on all 4 concrete GQL union types - Repeat fullDatabaseId per union fragment (shurcooL/githubv4 cannot use interface-level fragments at union top-level) - Add parseFullDatabaseID helper to parse BigInt string to int64 - Update tests to assert DatabaseID is populated from fullDatabaseId
pachecocordovamoiseseduardo-byte
approved these changes
May 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Exposes a numeric database identifier for issue fields returned by list_issue_fields, derived from the GraphQL fullDatabaseId (BigInt) scalar, and updates unit tests to validate the new field.
Changes:
- Added
DatabaseIDtoIssueFieldand populated it fromfullDatabaseIdacross all union member fragments. - Introduced
parseFullDatabaseIDhelper to parse the BigInt string intoint64. - Updated
Test_ListIssueFieldsfixtures and assertions to validateDatabaseID.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/issue_fields.go | Adds DatabaseID to the public output struct, fetches fullDatabaseId in GraphQL fragments, and parses it into int64. |
| pkg/github/issue_fields_test.go | Extends mocked GraphQL responses and assertions to ensure DatabaseID is populated correctly. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
| // IssueField represents a repository issue field definition. | ||
| type IssueField struct { | ||
| ID string `json:"id"` | ||
| DatabaseID int64 `json:"database_id,omitempty"` |
Comment on lines
+253
to
+264
| // parseFullDatabaseID converts a BigInt scalar string (e.g. "12345") to int64. | ||
| // Returns 0 if the string is empty or cannot be parsed. | ||
| func parseFullDatabaseID(s string) int64 { | ||
| if s == "" { | ||
| return 0 | ||
| } | ||
| n, err := strconv.ParseInt(s, 10, 64) | ||
| if err != nil { | ||
| return 0 | ||
| } | ||
| return n | ||
| } |
Comment on lines
+253
to
+260
| // parseFullDatabaseID converts a BigInt scalar string (e.g. "12345") to int64. | ||
| // Returns 0 if the string is empty or cannot be parsed. | ||
| func parseFullDatabaseID(s string) int64 { | ||
| if s == "" { | ||
| return 0 | ||
| } | ||
| n, err := strconv.ParseInt(s, 10, 64) | ||
| if err != nil { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issues.readandissues.write#2492 depends on thisSummary
Why
Fixes #
We are using this tool in two places:
Because of this, we need to have both node ID and database ID exposed in this tool so both other tools can use it.
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs