implement extraction of query ngrams#139
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds streaming query-time sparse n-gram extraction for future Blackbird integration.
Changes:
- Introduces cloneable, drainable
QueryGramsstate with case folding and tests. - Adds packed-window n-gram construction.
- Adds end indices to existing extractors and updates documentation and benchmarks.
Show a summary per file
| File | Description |
|---|---|
crates/sparse-ngrams/src/query.rs |
Implements streaming query extraction and tests. |
crates/sparse-ngrams/src/ngram.rs |
Adds masked-window construction. |
crates/sparse-ngrams/src/lib.rs |
Exports QueryGrams. |
crates/sparse-ngrams/src/extract.rs |
Adds callback end indices. |
crates/sparse-ngrams/README.md |
Updates callback example. |
crates/sparse-ngrams/Cargo.toml |
Adds casefold. |
crates/sparse-ngrams/benchmarks/performance.rs |
Updates benchmark callbacks. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 7/7 changed files
- Comments generated: 6
- Review effort level: Medium
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…gems into aneubeck/querygrams
itsibitzi
reviewed
Jul 20, 2026
itsibitzi
reviewed
Jul 20, 2026
itsibitzi
approved these changes
Jul 20, 2026
aneubeck
enabled auto-merge
July 20, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the query part which needs to be integrated into blackbird next.