refactor: enhance scaling configuration and resource management in tests - #141
Open
karimra wants to merge 5 commits into
Open
refactor: enhance scaling configuration and resource management in tests#141karimra wants to merge 5 commits into
karimra wants to merge 5 commits into
Conversation
karimra
commented
Aug 11, 2026
karimra
commented
Collaborator
- Updated test.mk to include new environment variables for scaling configuration: SCALE_REPLICAS, SCALE_CPU_REQUEST, SCALE_CPU_LIMIT, SCALE_MEMORY_REQUEST, and SCALE_MEMORY_LIMIT.
- Refactored integration tests to utilize new helper functions for managing subscription paths and outputs, improving test reliability and clarity.
- Adjusted baseline YAML to dynamically reference CPU and memory resource requests and limits, enhancing flexibility in scaling tests.
- Updated test.mk to include new environment variables for scaling configuration: SCALE_REPLICAS, SCALE_CPU_REQUEST, SCALE_CPU_LIMIT, SCALE_MEMORY_REQUEST, and SCALE_MEMORY_LIMIT. - Refactored integration tests to utilize new helper functions for managing subscription paths and outputs, improving test reliability and clarity. - Adjusted baseline YAML to dynamically reference CPU and memory resource requests and limits, enhancing flexibility in scaling tests.
Deploying gnmic-operator with
|
| Latest commit: |
f3192b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://927df36b.gnmic-operator2.pages.dev |
| Branch Preview URL: | https://test-suite-cont.gnmic-operator2.pages.dev |
gNMIc can ACK config/apply before every target re-subscribes; ApplyCache then short-circuited the same plan for 5m and left paths=[] long enough to flake Sub005/Sub010. Verify each hash with a second POST, and wait on fleet state atomically in those tests. Co-authored-by: Cursor <cursoragent@cursor.com>
TestOut006, TestTarget003, and TestOut003 sampled their invariant right after triggering a config apply or waiting on Cluster status, both of which can return before the actual gNMIc streams/Service exist. Wait for the settled state first so the assertion window doesn't start mid-reconnect. Co-authored-by: Cursor <cursoragent@cursor.com>
gNMIc's config/apply can ACK before every Subscribe stream has re-established, and rarely one never comes back on its own, leaving a target stuck with paths=[] indefinitely. Track whether an applied hash has been confirmed by a later reconcile; if it's still unverified after a 30s grace period, requeue and re-POST the same config once to kick the stream loose. The delay matters: firing the repost immediately (an earlier attempt) doubled every apply back-to-back and made pods work harder to reconnect right when they were already struggling, making CI flakes worse instead of better. 30s clears both unrelated reconcile churn and tests' own "stays stable" assertion windows. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.